Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: Source/core/rendering/RenderBox.cpp

Issue 683373002: Invalidate the frame view when changing the background image of the document or body. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Cleanup. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed.
7 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved. 7 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 1265 matching lines...) Expand 10 before | Expand all | Expand 10 after
1276 bool RenderBox::paintInvalidationLayerRectsForImage(WrappedImagePtr image, const FillLayer& layers, bool drawingBackground) 1276 bool RenderBox::paintInvalidationLayerRectsForImage(WrappedImagePtr image, const FillLayer& layers, bool drawingBackground)
1277 { 1277 {
1278 Vector<RenderObject*> layerRenderers; 1278 Vector<RenderObject*> layerRenderers;
1279 1279
1280 // A background of the body or document must extend to the total visible siz e of the document. This means the union of the 1280 // A background of the body or document must extend to the total visible siz e of the document. This means the union of the
1281 // view and document bounds, since it can be the case that the view is large r than the document and vice-versa. 1281 // view and document bounds, since it can be the case that the view is large r than the document and vice-versa.
1282 // http://dev.w3.org/csswg/css-backgrounds/#the-background 1282 // http://dev.w3.org/csswg/css-backgrounds/#the-background
1283 if (drawingBackground && (isDocumentElement() || (isBody() && !document().do cumentElement()->renderer()->hasBackground()))) { 1283 if (drawingBackground && (isDocumentElement() || (isBody() && !document().do cumentElement()->renderer()->hasBackground()))) {
1284 layerRenderers.append(document().documentElement()->renderer()); 1284 layerRenderers.append(document().documentElement()->renderer());
1285 layerRenderers.append(view()); 1285 layerRenderers.append(view());
1286 if (view()->frameView())
1287 view()->frameView()->setNeedsFullPaintInvalidation();
dsinclair 2014/10/31 00:14:34 What about doing view()->setShouldDoFullPaintInval
Xianzhu 2014/10/31 16:37:30 Would view()->setNeedsFullPaintInvalidation() work
1286 } else { 1288 } else {
1287 layerRenderers.append(this); 1289 layerRenderers.append(this);
1288 } 1290 }
1289 for (const FillLayer* curLayer = &layers; curLayer; curLayer = curLayer->nex t()) { 1291 for (const FillLayer* curLayer = &layers; curLayer; curLayer = curLayer->nex t()) {
1290 if (curLayer->image() && image == curLayer->image()->data() && curLayer- >image()->canRender(*this, style()->effectiveZoom())) { 1292 if (curLayer->image() && image == curLayer->image()->data() && curLayer- >image()->canRender(*this, style()->effectiveZoom())) {
1291 for (RenderObject* layerRenderer : layerRenderers) 1293 for (RenderObject* layerRenderer : layerRenderers)
1292 layerRenderer->setShouldDoFullPaintInvalidation(); 1294 layerRenderer->setShouldDoFullPaintInvalidation();
1293 return true; 1295 return true;
1294 } 1296 }
1295 } 1297 }
(...skipping 3131 matching lines...) Expand 10 before | Expand all | Expand 10 after
4427 4429
4428 setLogicalTop(oldLogicalTop); 4430 setLogicalTop(oldLogicalTop);
4429 setLogicalWidth(oldLogicalWidth); 4431 setLogicalWidth(oldLogicalWidth);
4430 setMarginLeft(oldMarginLeft); 4432 setMarginLeft(oldMarginLeft);
4431 setMarginRight(oldMarginRight); 4433 setMarginRight(oldMarginRight);
4432 4434
4433 return borderBox; 4435 return borderBox;
4434 } 4436 }
4435 4437
4436 } // namespace blink 4438 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698