Invalidate the frame view when changing the background image of the document or body.

Source/core/frame/FrameView.cpp

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999 Lars Knoll <knoll@kde.org>
  *                     1999 Antti Koivisto <koivisto@kde.org>
  *                     2000 Dirk Mueller <mueller@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  *           (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
@@ skipping 973 matching lines @@
         // do a full tree walk.
         if (RenderObject* container = rootForThisLayout->container())
             container->setMayNeedPaintInvalidation(true);
     } // Reset m_layoutSchedulingEnabled to its previous value.
 
     if (!inSubtreeLayout && !toRenderView(rootForThisLayout)->document().printing())
         adjustViewSize();
 
     layer->updateLayerPositionsAfterLayout();
 
-    if (m_doFullPaintInvalidation)
-        renderView()->compositor()->fullyInvalidatePaint();
     renderView()->compositor()->didLayout();
 
     m_layoutCount++;
 
     if (AXObjectCache* cache = rootForThisLayout->document().axObjectCache()) {
         const KURL& url = rootForThisLayout->document().url();
         if (url.isValid() && !url.isAboutBlankURL())
             cache->handleLayoutComplete(rootForThisLayout);
     }
     updateAnnotatedRegions();
@@ skipping 35 matching lines @@
 void FrameView::invalidateTreeIfNeeded()
 {
     ASSERT(renderView());
     RenderView& rootForPaintInvalidation = *renderView();
     ASSERT(!rootForPaintInvalidation.needsLayout());
 
     TRACE_EVENT1("blink", "FrameView::invalidateTree", "root", rootForPaintInvalidation.debugName().ascii());
 
     PaintInvalidationState rootPaintInvalidationState(rootForPaintInvalidation);
 
+    if (m_doFullPaintInvalidation)
+        renderView()->compositor()->fullyInvalidatePaint();
+
     rootForPaintInvalidation.invalidateTreeIfNeeded(rootPaintInvalidationState);
 
     // Invalidate the paint of the frameviews scrollbars if needed
     if (hasVerticalBarDamage())
         invalidateRect(verticalBarDamage());
     if (hasHorizontalBarDamage())
         invalidateRect(horizontalBarDamage());
     resetScrollbarDamage();
 
     m_doFullPaintInvalidation = false;
+
 #ifndef NDEBUG
     renderView()->assertSubtreeClearedPaintInvalidationState();
 #endif
 
     if (m_frame->selection().isCaretBoundsDirty())
         m_frame->selection().invalidateCaretRect();
 }
 
 DocumentLifecycle& FrameView::lifecycle() const
 {
@@ skipping 636 matching lines @@
     if (!frame().view())
         return;
 
     // Note that simply having overlay scrollbars is not sufficient to be
     // certain that scrollbars' presence does not impact layout. This should
     // also check if custom scrollbars (as reported by shouldUseCustomScrollbars)
     // are in use as well.
     // http://crbug.com/269692
     bool useOverlayScrollbars = ScrollbarTheme::theme()->usesOverlayScrollbars();
 
+    // FIXME: this call to layout() could be called within FrameView::layout(), but before performLayout(),
+    // causing double-layout.

[dsinclair, 2014/10/31 00:14:34]

Can you file a bug to track this?

[chrishtr, 2014/10/31 18:22:24]

Done.

     if (!useOverlayScrollbars && needsLayout())
         layout();
+    }

[dsinclair, 2014/10/31 00:14:34]

Don't think this should be here.

[chrishtr, 2014/10/31 18:22:24]

Done.

 
     if (renderView() && renderView()->usesCompositing()) {
         renderView()->compositor()->frameViewScrollbarsExistenceDidChange();
 
         if (!useOverlayScrollbars)
             renderView()->compositor()->frameViewDidChangeSize();
     }
 }
 
 void FrameView::handleLoadCompleted()
@@ skipping 2189 matching lines @@
         return;
 
     ScrollableArea::setScrollOrigin(origin);
 
     // Update if the scroll origin changes, since our position will be different if the content size did not change.
     if (updatePositionAtAll && updatePositionSynchronously)
         updateScrollbars(scrollOffsetDouble());
 }
 
 } // namespace blink