Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 683333002: Start running Chromoting auth tests for non-gmail and "Google Apps For Your Domanin" (GAFYD) accoun… (Closed)

Created:
6 years, 1 month ago by anandc
Modified:
6 years, 1 month ago
Reviewers:
Jamie
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add command lines that launch the Auth test with a non-gmail and a GAFYD account. BUG= Committed: https://crrev.com/2c62c78d43638394be241bf64600b5faf147fbcf Cr-Commit-Position: refs/heads/master@{#302003}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M testing/chromoting/browser_test_commands_linux.txt View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
anandc
Jamie, PTAL. Thanks.
6 years, 1 month ago (2014-10-28 22:55:57 UTC) #2
Jamie
Where are the new types defined? I don't see gafyd anywhere in the codebase.
6 years, 1 month ago (2014-10-28 23:06:22 UTC) #3
Jamie
Sorry, just saw the other CL. LGTM.
6 years, 1 month ago (2014-10-28 23:07:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/683333002/1
6 years, 1 month ago (2014-10-30 00:20:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-30 01:10:43 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 01:12:02 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c62c78d43638394be241bf64600b5faf147fbcf
Cr-Commit-Position: refs/heads/master@{#302003}

Powered by Google App Engine
This is Rietveld 408576698