Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 683313002: Revert of [Telemetry] Move some implementations from android_browser_backend_to android_platform_bac (Closed)

Created:
6 years, 1 month ago by wuhu
Modified:
6 years, 1 month ago
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of [Telemetry] Move some implementations from android_browser_backend_to android_platform_backend (patchset #7 id:120001 of https://codereview.chromium.org/656383002/) Reason for revert: 140688544552608:error:02001002:system library:fopen:No such file or directory:bss_file.c:398:fopen('/tmp/tmpLJeMcv/testca.pem','r') 140688544552608:error:20074002:BIO routines:FILE_CTRL:system lib:bss_file.c:400: unable to load certificate Original issue's description: > Code refactoring by moving implementations of the following functionalities from android_browser_backend to android_platform_backend: > setting SSL relax flag > application profile manipulation > setting debug app > kill app > port forwarding > dumping stack trace and standard output > root CA manipulation > > BUG=417542 > > Committed: https://crrev.com/6dd5949ca6ad88981576aa98aed22e8f4590c8aa > Cr-Commit-Position: refs/heads/master@{#301668} TBR=nednguyen@google.com,slamm@google.com,dtu@chromium.org,slamm@chromium.org,tonyg@chromium.org,nduca@chromium.org NOTREECHECKS=true NOTRY=true BUG=417542 Committed: https://crrev.com/92a18cf1920a8467ebb2017a9cbfe4bc7f8c07ba Cr-Commit-Position: refs/heads/master@{#301708}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -292 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py View 10 chunks +113 lines, -40 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/android_platform_backend.py View 6 chunks +7 lines, -252 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
wuhu
Created Revert of [Telemetry] Move some implementations from android_browser_backend_to android_platform_backend
6 years, 1 month ago (2014-10-28 21:04:29 UTC) #1
nednguyen
lgtm
6 years, 1 month ago (2014-10-28 21:05:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/683313002/1
6 years, 1 month ago (2014-10-28 21:07:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-28 21:09:35 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 21:10:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/92a18cf1920a8467ebb2017a9cbfe4bc7f8c07ba
Cr-Commit-Position: refs/heads/master@{#301708}

Powered by Google App Engine
This is Rietveld 408576698