Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: git_cl.py

Issue 683283006: Fix git cl comments when there's no issue associated with the current branch. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl.py
diff --git a/git_cl.py b/git_cl.py
index 48f6c26d4d8e7f729c5ca6c8d6951cc4ee05e226..ffff2c6a9a80cc8941c554d676935992d74c1a69 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -1462,7 +1462,7 @@ def CMDcomments(parser, args):
return 0
data = cl.GetIssueProperties()
- for message in sorted(data['messages'], key=lambda x: x['date']):
+ for message in sorted(data.get('messages', []), key=lambda x: x['date']):
if message['disapproval']:
color = Fore.RED
elif message['approval']:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698