Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 683243005: convert BitVector to use pointer size blocks (Closed)

Created:
6 years, 1 month ago by dcarney
Modified:
6 years, 1 month ago
Reviewers:
Sven Panne
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

convert BitVector to use pointer size blocks additionally rename data-flow.* to bit-vector.* as at some point these file became very inaccurately named BUG= R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25030

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -476 lines) Patch
M BUILD.gn View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A + src/bit-vector.h View 1 2 12 chunks +32 lines, -31 lines 0 comments Download
A + src/bit-vector.cc View 1 2 3 chunks +9 lines, -5 lines 0 comments Download
M src/compiler/ast-loop-assignment-analyzer.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/frame.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/scheduler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/verifier.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M src/data-flow.h View 1 2 1 chunk +0 lines, -252 lines 0 comments Download
M src/data-flow.cc View 1 2 1 chunk +0 lines, -54 lines 0 comments Download
M src/full-codegen.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen-instructions.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/cctest.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + test/cctest/test-bit-vector.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-dataflow.cc View 1 2 1 chunk +0 lines, -121 lines 0 comments Download
M tools/gyp/v8.gyp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Sven Panne
LGTM when the Win64 issue is fixed. https://codereview.chromium.org/683243005/diff/1/src/data-flow.cc File src/data-flow.cc (right): https://codereview.chromium.org/683243005/diff/1/src/data-flow.cc#newcode50 src/data-flow.cc:50: count += ...
6 years, 1 month ago (2014-10-31 10:18:54 UTC) #2
dcarney
6 years, 1 month ago (2014-10-31 10:44:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 25030 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698