Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 683233003: Revert of Referrer Policy: Update SanitizeForRequest with new default behavior. (Closed)

Created:
6 years, 1 month ago by Mike West
Modified:
6 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mcasas+watch_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Referrer Policy: Update SanitizeForRequest with new default behavior. (patchset #2 id:20001 of https://codereview.chromium.org/689363003/) Reason for revert: Doesn't compile on the debug bot. ?! Original issue's description: > Referrer Policy: Update SanitizeForRequest with new default behavior. > > Currently, we'll crash when this method is called if a site sets > `NoReferrerWhenDowngrade`. That seems like something worth fixing. :) > > BUG=431711 > > Committed: https://crrev.com/3b0e841aa8b7d5ca5999f4340b8fa6f73305d3d2 > Cr-Commit-Position: refs/heads/master@{#303629} TBR=jochen@chromium.org NOTREECHECKS=true NOTRY=true BUG=431711 Committed: https://crrev.com/c48f7c3c2037f98037533971a459f56a16c40ceb Cr-Commit-Position: refs/heads/master@{#303631}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -14 lines) Patch
M content/public/common/referrer.h View 2 chunks +2 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mike West
Created Revert of Referrer Policy: Update SanitizeForRequest with new default behavior.
6 years, 1 month ago (2014-11-11 12:42:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/683233003/1
6 years, 1 month ago (2014-11-11 12:43:05 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-11 12:43:31 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c48f7c3c2037f98037533971a459f56a16c40ceb Cr-Commit-Position: refs/heads/master@{#303631}
6 years, 1 month ago (2014-11-11 12:44:17 UTC) #4
Mike West
6 years, 1 month ago (2014-11-11 13:22:15 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/715513004/ by mkwst@chromium.org.

The reason for reverting is: Testing..

Powered by Google App Engine
This is Rietveld 408576698