Chromium Code Reviews Chromium Code Reviews
Issue 68323005:
Build libaddressinput in Chrome for requestAutocomplete(). (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src| OLD | NEW |
|---|---|
| (Empty) | |
| 1 # Copyright 2013 The Chromium Authors. All rights reserved. | |
| 2 # Use of this source code is governed by a BSD-style license that can be | |
| 3 # found in the LICENSE file. | |
| 4 { | |
| 5 'target_defaults': { | |
| 6 'cflags!': [ | |
| 7 '-fvisibility=hidden', | |
| 8 ], | |
| 9 }, | |
| 10 'targets': [ | |
| 11 { | |
| 12 'target_name': 'generated_messages', | |
| 13 'type': 'none', | |
| 14 'variables': { | |
| 15 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/libaddressinput/', | |
| 16 }, | |
| 17 'actions': [ | |
| 18 { | |
| 19 'action_name': 'generate_messages', | |
| 20 'variables': { | |
| 21 'grit_grd_file': 'src/cpp/res/messages.grd', | |
| 22 }, | |
| 23 'includes': [ | |
| 24 '../../build/grit_action.gypi', | |
| 25 ], | |
| 26 }, | |
| 27 ], | |
| 28 'includes': [ | |
| 29 '../../build/grit_target.gypi', | |
| 30 ], | |
| 31 }, | |
| 32 { | |
| 33 'target_name': 'libaddressinput', | |
| 34 'type': '<(component)', | |
| 35 'include_dirs': [ | |
| 36 # List chromium/ directory first to pick up "util/json.h" as an include. | |
| 37 'chromium/', | |
| 38 '<(DEPTH)/', | |
| 39 'src/cpp/include/', | |
| 40 'src/cpp/src/', | |
|
please use gerrit instead
2013/11/20 00:03:10
The files in 'cpp/src/src' use quotation marks ""
Dan Beam
2013/11/20 00:53:48
Done.
| |
| 41 '<(SHARED_INTERMEDIATE_DIR)/libaddressinput/', | |
| 42 ], | |
| 43 'sources': [ | |
| 44 'chromium/util/json.cc', | |
| 45 'chromium/util/json.h', | |
| 46 'src/cpp/include/libaddressinput/address_field.h', | |
| 47 'src/cpp/include/libaddressinput/address_ui_component.h', | |
| 48 'src/cpp/include/libaddressinput/address_ui.h', | |
| 49 'src/cpp/include/libaddressinput/localization.h', | |
| 50 'src/cpp/src/address_field.cc', | |
| 51 'src/cpp/src/address_field_util.cc', | |
| 52 'src/cpp/src/address_ui.cc', | |
| 53 'src/cpp/src/localization.cc', | |
| 54 'src/cpp/src/region_data_constants.cc', | |
| 55 'src/cpp/src/rule.cc', | |
|
please use gerrit instead
2013/11/20 00:03:10
If you're including all of the header files in the
Dan Beam
2013/11/20 00:53:48
Done.
| |
| 56 ], | |
| 57 'dependencies': [ | |
| 58 'generated_messages', | |
| 59 '<(DEPTH)/base/base.gyp:base', | |
| 60 ], | |
| 61 'direct_dependent_settings': { | |
| 62 'include_dirs': [ | |
| 63 'chromium/', | |
| 64 '<(DEPTH)/', | |
| 65 'src/cpp/include/', | |
| 66 'src/cpp/src/', | |
| 67 '<(SHARED_INTERMEDIATE_DIR)/libaddressinput/', | |
|
please use gerrit instead
2013/11/20 00:03:10
Direct depending settings are settings for the aut
Dan Beam
2013/11/20 00:53:48
Done.
| |
| 68 ], | |
| 69 }, | |
| 70 }, | |
| 71 { | |
| 72 'target_name': 'libaddressinput_unittests', | |
| 73 'type': '<(gtest_target_type)', | |
| 74 'include_dirs+': [ | |
| 75 '<(DEPTH)/testing/gtest/include/', | |
| 76 ], | |
| 77 'sources': [ | |
| 78 'src/cpp/test/address_field_util_test.cc', | |
| 79 'src/cpp/test/address_ui_test.cc', | |
| 80 'src/cpp/test/localization_test.cc', | |
| 81 'src/cpp/test/region_data_constants_test.cc', | |
| 82 'src/cpp/test/rule_test.cc', | |
| 83 'src/cpp/test/util/json_test.cc', | |
| 84 ], | |
| 85 'dependencies': [ | |
| 86 'libaddressinput', | |
| 87 '<(DEPTH)/base/base.gyp:run_all_unittests', | |
|
please use gerrit instead
2013/11/20 00:03:10
'libaddressinput_unittests' depends on 'run_all_un
Dan Beam
2013/11/20 00:53:48
look up run_all_unittests
| |
| 88 '<(DEPTH)/testing/gtest.gyp:gtest', | |
| 89 ], | |
| 90 }, | |
| 91 ], | |
| 92 } | |
| OLD | NEW |
