Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 68323004: Port Mojo's sample_service.cc to JavaScript (Closed)

Created:
7 years, 1 month ago by abarth-chromium
Modified:
7 years, 1 month ago
CC:
chromium-reviews, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Port Mojo's sample_service.cc to JavaScript This CL completes the manual implementation of sample_service.js and tests it using sample_test.js, which exactly mirrors the testing of sample_service.cc by sample_service.cc. (I've also moved sample_service.js into mojo/public/bindings/sample/mojom to better mirror the C++ implementation.) BUG=317398 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235917

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+410 lines, -107 lines) Patch
M gin/runner.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M mojo/public/bindings/js/codec.js View 2 chunks +7 lines, -1 line 2 comments Download
M mojo/public/bindings/js/codec_unittests.js View 2 chunks +32 lines, -1 line 0 comments Download
M mojo/public/bindings/js/core.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/public/bindings/js/test/run_js_tests.cc View 1 chunk +12 lines, -0 lines 0 comments Download
D mojo/public/bindings/js/test/sample_service.js View 1 chunk +0 lines, -99 lines 0 comments Download
A mojo/public/bindings/sample/mojom/sample_service.js View 1 chunk +229 lines, -0 lines 2 comments Download
A mojo/public/bindings/sample/sample_test.js View 1 chunk +123 lines, -0 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
abarth-chromium
Please take a look. Thanks! https://codereview.chromium.org/68323004/diff/1/mojo/public/bindings/js/codec.js File mojo/public/bindings/js/codec.js (left): https://codereview.chromium.org/68323004/diff/1/mojo/public/bindings/js/codec.js#oldcode394 mojo/public/bindings/js/codec.js:394: exports.load32 = load32; We ...
7 years, 1 month ago (2013-11-18 23:30:43 UTC) #1
Aaron Boodman
lgtm
7 years, 1 month ago (2013-11-19 01:09:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/68323004/1
7 years, 1 month ago (2013-11-19 01:37:04 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-19 04:33:17 UTC) #4
Message was sent while issue was closed.
Change committed as 235917

Powered by Google App Engine
This is Rietveld 408576698