minidump: Add InitializeFromSnapshot() for MinidumpModuleCrashpadInfoListWriter and downstream

minidump: Add InitializeFromSnapshot() for
MinidumpModuleCrashpadInfoListWriter and everything downstream.

TEST=minidump_test
R=rsesek@chromium.org

Committed: https://chromium.googlesource.com/crashpad/crashpad/+/765e42832140a7e75f6ed57c36034dbbec3785cd

[Mark Mentovai, 2014-10-28 17:02:30]

mark@chromium.org changed reviewers:
+ rsesek@chromium.org

[Robert Sesek, 2014-10-28 19:39:16]

https://codereview.chromium.org/683143003/diff/1/minidump/minidump_module_cra...
File minidump/minidump_module_crashpad_info_writer.h (right):

https://codereview.chromium.org/683143003/diff/1/minidump/minidump_module_cra...
minidump/minidump_module_crashpad_info_writer.h:49: //! \note Valid in
#kStateMutable. No mutator methods may be called before
Do you want to mention that this will ignore !IsUseful() snapshots, like you do
below?

https://codereview.chromium.org/683143003/diff/1/snapshot/test/test_module_sn...
File snapshot/test/test_module_snapshot.h (right):

https://codereview.chromium.org/683143003/diff/1/snapshot/test/test_module_sn...
snapshot/test/test_module_snapshot.h:75: std::string Name() const override;
Why inline the setters and not the getters, or vice versa?

[Mark Mentovai, 2014-10-28 20:43:01]

Updated.

https://codereview.chromium.org/683143003/diff/1/snapshot/test/test_module_sn...
File snapshot/test/test_module_snapshot.h (right):

https://codereview.chromium.org/683143003/diff/1/snapshot/test/test_module_sn...
snapshot/test/test_module_snapshot.h:75: std::string Name() const override;
Robert Sesek wrote:
> Why inline the setters and not the getters, or vice versa?

The getters are virtual, so I want them in a .cc file where they’ll produce
exactly one definition and a complete vtable.

I could also un-inline the setters if you’d like.

[Robert Sesek, 2014-10-28 20:54:01]

LGTM

https://codereview.chromium.org/683143003/diff/1/snapshot/test/test_module_sn...
File snapshot/test/test_module_snapshot.h (right):

https://codereview.chromium.org/683143003/diff/1/snapshot/test/test_module_sn...
snapshot/test/test_module_snapshot.h:75: std::string Name() const override;
On 2014/10/28 20:43:00, Mark Mentovai wrote:
> Robert Sesek wrote:
> > Why inline the setters and not the getters, or vice versa?
> 
> The getters are virtual, so I want them in a .cc file where they’ll produce
> exactly one definition and a complete vtable.
> 
> I could also un-inline the setters if you’d like.

No, it's fine.

[Mark Mentovai, 2014-10-28 21:00:52]

Committed patchset #2 (id:20001) manually as
765e42832140a7e75f6ed57c36034dbbec3785cd (presubmit successful).