Issue 683123003: Remove unneeded file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 683123003: Remove unneeded file. (Closed)

Created:
6 years, 1 month ago by scroggo

Modified:
6 years, 1 month ago

Reviewers:
djsollen

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Remove unneeded file. public_headers.gypi was never needed by Skia proper, and was almost always out of date. Its actual user no longer needs it, so stop updating it with every other change to public headers. BUG=skia:2350 Committed: https://skia.googlesource.com/skia/+/8f0d69e48eef2b87d0149729adcfa058e8c42c81

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -10 lines)			Patch
	D	gyp/public_headers.gypi	View		1 chunk	+0 lines, -10 lines	0 comments	Download

Total messages: 6 (2 generated)

scroggo

Depends on https://codereview.chromium.org/639423005/ in chromium.

6 years, 1 month ago (2014-10-28 15:52:54 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/683123003/1

6 years, 1 month ago (2014-10-28 15:58:08 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-10-28 17:27:54 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 8f0d69e48eef2b87d0149729adcfa058e8c42c81