Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1569)

Unified Diff: sandbox/linux/bpf_dsl/bpf_dsl_unittest.cc

Issue 683113005: Update from chromium https://crrev.com/302282 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sandbox/linux/bpf_dsl/bpf_dsl_more_unittest.cc ('k') | sandbox/linux/sandbox_linux.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/linux/bpf_dsl/bpf_dsl_unittest.cc
diff --git a/sandbox/linux/bpf_dsl/bpf_dsl_unittest.cc b/sandbox/linux/bpf_dsl/bpf_dsl_unittest.cc
index eb63e8c1ace234a40940c07dafeb40ad69cb448f..6c2875f94a4a15a80a6a16729952960efcc1264e 100644
--- a/sandbox/linux/bpf_dsl/bpf_dsl_unittest.cc
+++ b/sandbox/linux/bpf_dsl/bpf_dsl_unittest.cc
@@ -64,8 +64,8 @@ class Stubs {
class BasicPolicy : public Policy {
public:
BasicPolicy() {}
- virtual ~BasicPolicy() {}
- virtual ResultExpr EvaluateSyscall(int sysno) const override {
+ ~BasicPolicy() override {}
+ ResultExpr EvaluateSyscall(int sysno) const override {
if (sysno == __NR_getpgid) {
const Arg<pid_t> pid(0);
return If(pid == 0, Error(EPERM)).Else(Error(EINVAL));
@@ -94,8 +94,8 @@ BPF_TEST_C(BPFDSL, Basic, BasicPolicy) {
class BooleanLogicPolicy : public Policy {
public:
BooleanLogicPolicy() {}
- virtual ~BooleanLogicPolicy() {}
- virtual ResultExpr EvaluateSyscall(int sysno) const override {
+ ~BooleanLogicPolicy() override {}
+ ResultExpr EvaluateSyscall(int sysno) const override {
if (sysno == __NR_socketpair) {
const Arg<int> domain(0), type(1), protocol(2);
return If(domain == AF_UNIX &&
@@ -132,8 +132,8 @@ BPF_TEST_C(BPFDSL, BooleanLogic, BooleanLogicPolicy) {
class MoreBooleanLogicPolicy : public Policy {
public:
MoreBooleanLogicPolicy() {}
- virtual ~MoreBooleanLogicPolicy() {}
- virtual ResultExpr EvaluateSyscall(int sysno) const override {
+ ~MoreBooleanLogicPolicy() override {}
+ ResultExpr EvaluateSyscall(int sysno) const override {
if (sysno == __NR_setresuid) {
const Arg<uid_t> ruid(0), euid(1), suid(2);
return If(ruid == 0 || euid == 0 || suid == 0, Error(EPERM))
@@ -169,8 +169,8 @@ static const uintptr_t kDeadBeefAddr =
class ArgSizePolicy : public Policy {
public:
ArgSizePolicy() {}
- virtual ~ArgSizePolicy() {}
- virtual ResultExpr EvaluateSyscall(int sysno) const override {
+ ~ArgSizePolicy() override {}
+ ResultExpr EvaluateSyscall(int sysno) const override {
if (sysno == __NR_uname) {
const Arg<uintptr_t> addr(0);
return If(addr == kDeadBeefAddr, Error(EPERM)).Else(Allow());
@@ -192,8 +192,8 @@ BPF_TEST_C(BPFDSL, ArgSizeTest, ArgSizePolicy) {
class TrappingPolicy : public Policy {
public:
TrappingPolicy() {}
- virtual ~TrappingPolicy() {}
- virtual ResultExpr EvaluateSyscall(int sysno) const override {
+ ~TrappingPolicy() override {}
+ ResultExpr EvaluateSyscall(int sysno) const override {
if (sysno == __NR_uname) {
return Trap(UnameTrap, &count_);
}
@@ -222,8 +222,8 @@ BPF_TEST_C(BPFDSL, TrapTest, TrappingPolicy) {
class MaskingPolicy : public Policy {
public:
MaskingPolicy() {}
- virtual ~MaskingPolicy() {}
- virtual ResultExpr EvaluateSyscall(int sysno) const override {
+ ~MaskingPolicy() override {}
+ ResultExpr EvaluateSyscall(int sysno) const override {
if (sysno == __NR_setuid) {
const Arg<uid_t> uid(0);
return If((uid & 0xf) == 0, Error(EINVAL)).Else(Error(EACCES));
@@ -263,8 +263,8 @@ BPF_TEST_C(BPFDSL, MaskTest, MaskingPolicy) {
class ElseIfPolicy : public Policy {
public:
ElseIfPolicy() {}
- virtual ~ElseIfPolicy() {}
- virtual ResultExpr EvaluateSyscall(int sysno) const override {
+ ~ElseIfPolicy() override {}
+ ResultExpr EvaluateSyscall(int sysno) const override {
if (sysno == __NR_setuid) {
const Arg<uid_t> uid(0);
return If((uid & 0xfff) == 0, Error(0))
@@ -295,8 +295,8 @@ BPF_TEST_C(BPFDSL, ElseIfTest, ElseIfPolicy) {
class SwitchPolicy : public Policy {
public:
SwitchPolicy() {}
- virtual ~SwitchPolicy() {}
- virtual ResultExpr EvaluateSyscall(int sysno) const override {
+ ~SwitchPolicy() override {}
+ ResultExpr EvaluateSyscall(int sysno) const override {
if (sysno == __NR_fcntl) {
const Arg<int> cmd(1);
const Arg<unsigned long> long_arg(2);
« no previous file with comments | « sandbox/linux/bpf_dsl/bpf_dsl_more_unittest.cc ('k') | sandbox/linux/sandbox_linux.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698