Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: build/android/pylib/device/adb_wrapper.py

Issue 683113005: Update from chromium https://crrev.com/302282 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/native_app_dependencies.gypi ('k') | build/android/pylib/device/device_utils.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/device/adb_wrapper.py
diff --git a/build/android/pylib/device/adb_wrapper.py b/build/android/pylib/device/adb_wrapper.py
index f6ac660c276176c5bd75ded89fac57f63cf70243..97f387ada22f9b79dfdea6e00d1bd4021883a6a9 100644
--- a/build/android/pylib/device/adb_wrapper.py
+++ b/build/android/pylib/device/adb_wrapper.py
@@ -14,6 +14,7 @@ import os
from pylib import cmd_helper
from pylib.device import decorators
from pylib.device import device_errors
+from pylib.utils import timeout_retry
_DEFAULT_TIMEOUT = 30
@@ -49,10 +50,11 @@ class AdbWrapper(object):
@decorators.WithTimeoutAndRetries
def _RunAdbCmd(cls, arg_list, timeout=None, retries=None, check_error=True):
cmd = ['adb'] + arg_list
- exit_code, output = cmd_helper.GetCmdStatusAndOutput(cmd)
+ exit_code, output = cmd_helper.GetCmdStatusAndOutputWithTimeout(
+ cmd, timeout_retry.CurrentTimeoutThread().GetRemainingTime())
if exit_code != 0:
raise device_errors.AdbCommandFailedError(
- cmd, 'returned non-zero exit code %s, output: %s' %
+ cmd, 'returned non-zero exit code %d and output %r' %
(exit_code, output))
# This catches some errors, including when the device drops offline;
# unfortunately adb is very inconsistent with error reporting so many
« no previous file with comments | « build/android/native_app_dependencies.gypi ('k') | build/android/pylib/device/device_utils.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698