tools/clang/plugins/FindBadConstructsConsumer.cpp - Issue 683113005: Update from chromium https://crrev.com/302282

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/plugins/FindBadConstructsConsumer.cpp

Issue 683113005: Update from chromium https://crrev.com/302282 (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/clang/plugins/FindBadConstructsConsumer.cpp

diff --git a/tools/clang/plugins/FindBadConstructsConsumer.cpp b/tools/clang/plugins/FindBadConstructsConsumer.cpp

index a608cd29d172e6ab6939a9a574c4ac6e20a93c21..0a230e0fcdb106e2487c2bee2af3c88d73c6f6e4 100644

--- a/tools/clang/plugins/FindBadConstructsConsumer.cpp

+++ b/tools/clang/plugins/FindBadConstructsConsumer.cpp

@@ -364,7 +364,7 @@ void FindBadConstructsConsumer::CheckVirtualSpecifiers(

OverrideAttr* override_attr = method->getAttr<OverrideAttr>();

FinalAttr* final_attr = method->getAttr<FinalAttr>();

- if (method->isPure())

+ if (method->isPure() && !options_.strict_virtual_specifiers)

return;

if (IsMethodInBannedOrTestingNamespace(method))