Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1122)

Unified Diff: cc/output/gl_renderer_unittest.cc

Issue 683113005: Update from chromium https://crrev.com/302282 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/output/gl_renderer.cc ('k') | cc/output/overlay_strategy_single_on_top.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/gl_renderer_unittest.cc
diff --git a/cc/output/gl_renderer_unittest.cc b/cc/output/gl_renderer_unittest.cc
index 8de90c469acb10b78f78909d0b1a8ace4e45d843..dc686757cf87a63bedbe84347304552d1819d967 100644
--- a/cc/output/gl_renderer_unittest.cc
+++ b/cc/output/gl_renderer_unittest.cc
@@ -114,18 +114,6 @@ class GLRendererShaderPixelTest : public GLRendererPixelTest {
renderer()->GetRenderPassProgram(precision, blend_mode));
EXPECT_PROGRAM_VALID(
renderer()->GetRenderPassProgramAA(precision, blend_mode));
- EXPECT_PROGRAM_VALID(
- renderer()->GetRenderPassMaskProgram(precision, blend_mode));
- EXPECT_PROGRAM_VALID(
- renderer()->GetRenderPassMaskProgramAA(precision, blend_mode));
- EXPECT_PROGRAM_VALID(
- renderer()->GetRenderPassColorMatrixProgram(precision, blend_mode));
- EXPECT_PROGRAM_VALID(renderer()->GetRenderPassMaskColorMatrixProgramAA(
- precision, blend_mode));
- EXPECT_PROGRAM_VALID(
- renderer()->GetRenderPassColorMatrixProgramAA(precision, blend_mode));
- EXPECT_PROGRAM_VALID(renderer()->GetRenderPassMaskColorMatrixProgram(
- precision, blend_mode));
}
EXPECT_PROGRAM_VALID(renderer()->GetTextureProgram(precision));
EXPECT_PROGRAM_VALID(
@@ -158,6 +146,17 @@ class GLRendererShaderPixelTest : public GLRendererPixelTest {
renderer()->GetTileProgramSwizzleOpaque(precision, sampler));
EXPECT_PROGRAM_VALID(
renderer()->GetTileProgramSwizzleAA(precision, sampler));
+ for (int i = 0; i < NumBlendModes; ++i) {
+ BlendMode blend_mode = static_cast<BlendMode>(i);
+ EXPECT_PROGRAM_VALID(
+ renderer()->GetRenderPassMaskProgram(precision, sampler, blend_mode));
+ EXPECT_PROGRAM_VALID(renderer()->GetRenderPassMaskProgramAA(
+ precision, sampler, blend_mode));
+ EXPECT_PROGRAM_VALID(renderer()->GetRenderPassMaskColorMatrixProgramAA(
+ precision, sampler, blend_mode));
+ EXPECT_PROGRAM_VALID(renderer()->GetRenderPassMaskColorMatrixProgram(
+ precision, sampler, blend_mode));
+ }
}
};
@@ -266,23 +265,24 @@ class GLRendererShaderTest : public GLRendererTest {
}
void TestRenderPassMaskProgram(TexCoordPrecision precision,
+ SamplerType sampler,
BlendMode blend_mode) {
EXPECT_PROGRAM_VALID(
- &renderer_->render_pass_mask_program_[precision][blend_mode]);
+ &renderer_->render_pass_mask_program_[precision][sampler][blend_mode]);
EXPECT_EQ(
- renderer_->render_pass_mask_program_[precision][blend_mode].program(),
+ renderer_->render_pass_mask_program_[precision][sampler][blend_mode]
+ .program(),
renderer_->program_shadow_);
}
void TestRenderPassMaskColorMatrixProgram(TexCoordPrecision precision,
+ SamplerType sampler,
BlendMode blend_mode) {
- EXPECT_PROGRAM_VALID(
- &renderer_
- ->render_pass_mask_color_matrix_program_[precision][blend_mode]);
- EXPECT_EQ(
- renderer_->render_pass_mask_color_matrix_program_[precision][blend_mode]
- .program(),
- renderer_->program_shadow_);
+ EXPECT_PROGRAM_VALID(&renderer_->render_pass_mask_color_matrix_program_
+ [precision][sampler][blend_mode]);
+ EXPECT_EQ(renderer_->render_pass_mask_color_matrix_program_
+ [precision][sampler][blend_mode].program(),
+ renderer_->program_shadow_);
}
void TestRenderPassProgramAA(TexCoordPrecision precision,
@@ -306,23 +306,25 @@ class GLRendererShaderTest : public GLRendererTest {
}
void TestRenderPassMaskProgramAA(TexCoordPrecision precision,
+ SamplerType sampler,
BlendMode blend_mode) {
EXPECT_PROGRAM_VALID(
- &renderer_->render_pass_mask_program_aa_[precision][blend_mode]);
- EXPECT_EQ(renderer_->render_pass_mask_program_aa_[precision][blend_mode]
- .program(),
- renderer_->program_shadow_);
+ &renderer_
+ ->render_pass_mask_program_aa_[precision][sampler][blend_mode]);
+ EXPECT_EQ(
+ renderer_->render_pass_mask_program_aa_[precision][sampler][blend_mode]
+ .program(),
+ renderer_->program_shadow_);
}
void TestRenderPassMaskColorMatrixProgramAA(TexCoordPrecision precision,
+ SamplerType sampler,
BlendMode blend_mode) {
EXPECT_PROGRAM_VALID(&renderer_->render_pass_mask_color_matrix_program_aa_
- [precision][blend_mode]);
- EXPECT_EQ(
- renderer_
- ->render_pass_mask_color_matrix_program_aa_[precision][blend_mode]
- .program(),
- renderer_->program_shadow_);
+ [precision][sampler][blend_mode]);
+ EXPECT_EQ(renderer_->render_pass_mask_color_matrix_program_aa_
+ [precision][sampler][blend_mode].program(),
+ renderer_->program_shadow_);
}
void TestSolidColorProgramAA() {
@@ -1499,7 +1501,8 @@ TEST_F(GLRendererShaderTest, DrawRenderPassQuadShaderPermutations) {
viewport_rect,
viewport_rect,
false);
- TestRenderPassMaskProgram(TexCoordPrecisionMedium, blend_mode);
+ TestRenderPassMaskProgram(
+ TexCoordPrecisionMedium, SamplerType2D, blend_mode);
// RenderPassMaskColorMatrixProgram
render_passes_in_draw_order_.clear();
@@ -1524,7 +1527,8 @@ TEST_F(GLRendererShaderTest, DrawRenderPassQuadShaderPermutations) {
viewport_rect,
viewport_rect,
false);
- TestRenderPassMaskColorMatrixProgram(TexCoordPrecisionMedium, blend_mode);
+ TestRenderPassMaskColorMatrixProgram(
+ TexCoordPrecisionMedium, SamplerType2D, blend_mode);
// RenderPassProgramAA
render_passes_in_draw_order_.clear();
@@ -1607,7 +1611,8 @@ TEST_F(GLRendererShaderTest, DrawRenderPassQuadShaderPermutations) {
viewport_rect,
viewport_rect,
false);
- TestRenderPassMaskProgramAA(TexCoordPrecisionMedium, blend_mode);
+ TestRenderPassMaskProgramAA(
+ TexCoordPrecisionMedium, SamplerType2D, blend_mode);
// RenderPassMaskColorMatrixProgramAA
render_passes_in_draw_order_.clear();
@@ -1632,7 +1637,8 @@ TEST_F(GLRendererShaderTest, DrawRenderPassQuadShaderPermutations) {
viewport_rect,
viewport_rect,
false);
- TestRenderPassMaskColorMatrixProgramAA(TexCoordPrecisionMedium, blend_mode);
+ TestRenderPassMaskColorMatrixProgramAA(
+ TexCoordPrecisionMedium, SamplerType2D, blend_mode);
}
}
« no previous file with comments | « cc/output/gl_renderer.cc ('k') | cc/output/overlay_strategy_single_on_top.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698