Update from chromium https://crrev.com/302282

cc/resources/one_copy_raster_worker_pool.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/resources/one_copy_raster_worker_pool.h"
 
 #include <algorithm>
 #include <limits>
 
 #include "base/debug/trace_event.h"
@@ skipping 29 matching lines @@
     // Release write lock in case a copy was never scheduled.
     lock_.reset();
 
     // Make sure any scheduled copy operations are issued before we release the
     // raster resource.
     if (sequence_)
       worker_pool_->AdvanceLastIssuedCopyTo(sequence_);
 
     // Return raster resource to pool so it can be used by another RasterBuffer
     // instance.
-    resource_pool_->ReleaseResource(raster_resource_.Pass());
+    if (raster_resource_)
+      resource_pool_->ReleaseResource(raster_resource_.Pass());
   }
 
   // Overridden from RasterBuffer:
   void Playback(const RasterSource* raster_source,
                 const gfx::Rect& rect,
                 float scale,
                 RenderingStatsInstrumentation* stats) override {
-    gfx::GpuMemoryBuffer* gpu_memory_buffer = lock_->GetGpuMemoryBuffer();
-    if (!gpu_memory_buffer)
-      return;
-
-    RasterWorkerPool::PlaybackToMemory(gpu_memory_buffer->Map(),
-                                       raster_resource_->format(),
-                                       raster_resource_->size(),
-                                       gpu_memory_buffer->GetStride(),
-                                       raster_source,
-                                       rect,
-                                       scale,
-                                       stats);
-    gpu_memory_buffer->Unmap();
-
-    sequence_ = worker_pool_->ScheduleCopyOnWorkerThread(
-        lock_.Pass(), raster_resource_.get(), resource_);
+    sequence_ = worker_pool_->PlaybackAndScheduleCopyOnWorkerThread(
+        lock_.Pass(),
+        raster_resource_.Pass(),
+        resource_,
+        raster_source,
+        rect,
+        scale,
+        stats);
   }
 
  private:
   OneCopyRasterWorkerPool* worker_pool_;
   ResourceProvider* resource_provider_;
   ResourcePool* resource_pool_;
   const Resource* resource_;
   scoped_ptr<ScopedResource> raster_resource_;
   scoped_ptr<ResourceProvider::ScopedWriteLockGpuMemoryBuffer> lock_;
   CopySequenceNumber sequence_;
 
   DISALLOW_COPY_AND_ASSIGN(RasterBufferImpl);
 };
 
 // Flush interval when performing copy operations.
 const int kCopyFlushPeriod = 4;
 
+// Number of in-flight copy operations to allow.
+const int kMaxCopyOperations = 16;
+
+// Delay been checking for copy operations to complete.
+const int kCheckForCompletedCopyOperationsTickRateMs = 1;
+
+// Number of failed attempts to allow before we perform a check that will
+// wait for copy operations to complete if needed.
+const int kFailedAttemptsBeforeWaitIfNeeded = 256;
+
 }  // namespace
 
 OneCopyRasterWorkerPool::CopyOperation::CopyOperation(
     scoped_ptr<ResourceProvider::ScopedWriteLockGpuMemoryBuffer> write_lock,
-    ResourceProvider::ResourceId src,
-    ResourceProvider::ResourceId dst)
-    : write_lock(write_lock.Pass()), src(src), dst(dst) {
+    scoped_ptr<ScopedResource> src,
+    const Resource* dst)
+    : write_lock(write_lock.Pass()), src(src.Pass()), dst(dst) {
 }
 
 OneCopyRasterWorkerPool::CopyOperation::~CopyOperation() {
 }
 
 // static
 scoped_ptr<RasterWorkerPool> OneCopyRasterWorkerPool::Create(
     base::SequencedTaskRunner* task_runner,
     TaskGraphRunner* task_graph_runner,
     ContextProvider* context_provider,
@@ skipping 14 matching lines @@
     ResourceProvider* resource_provider,
     ResourcePool* resource_pool)
     : task_runner_(task_runner),
       task_graph_runner_(task_graph_runner),
       namespace_token_(task_graph_runner->GetNamespaceToken()),
       context_provider_(context_provider),
       resource_provider_(resource_provider),
       resource_pool_(resource_pool),
       last_issued_copy_operation_(0),
       last_flushed_copy_operation_(0),
+      lock_(),
+      copy_operation_count_cv_(&lock_),
+      scheduled_copy_operation_count_(0),
+      issued_copy_operation_count_(0),
       next_copy_operation_sequence_(1),
+      check_for_completed_copy_operations_pending_(false),
+      shutdown_(false),
       weak_ptr_factory_(this),
       raster_finished_weak_ptr_factory_(this) {
   DCHECK(context_provider_);
 }
 
 OneCopyRasterWorkerPool::~OneCopyRasterWorkerPool() {
+  DCHECK_EQ(scheduled_copy_operation_count_, 0u);
 }
 
 Rasterizer* OneCopyRasterWorkerPool::AsRasterizer() {
   return this;
 }
 
 void OneCopyRasterWorkerPool::SetClient(RasterizerClient* client) {
   client_ = client;
 }
 
 void OneCopyRasterWorkerPool::Shutdown() {
   TRACE_EVENT0("cc", "OneCopyRasterWorkerPool::Shutdown");
 
+  {
+    base::AutoLock lock(lock_);
+
+    shutdown_ = true;
+    copy_operation_count_cv_.Signal();
+  }
+
   TaskGraph empty;
   task_graph_runner_->ScheduleTasks(namespace_token_, &empty);
   task_graph_runner_->WaitForTasksToFinishRunning(namespace_token_);
 }
 
 void OneCopyRasterWorkerPool::ScheduleTasks(RasterTaskQueue* queue) {
   TRACE_EVENT0("cc", "OneCopyRasterWorkerPool::ScheduleTasks");
 
   if (raster_pending_.none())
     TRACE_EVENT_ASYNC_BEGIN0("cc", "ScheduledTasks", this);
@@ skipping 13 matching lines @@
   size_t task_count[kNumberOfTaskSets] = {0};
 
   for (TaskSet task_set = 0; task_set < kNumberOfTaskSets; ++task_set) {
     new_raster_finished_tasks[task_set] = CreateRasterFinishedTask(
         task_runner_.get(),
         base::Bind(&OneCopyRasterWorkerPool::OnRasterFinished,
                    raster_finished_weak_ptr_factory_.GetWeakPtr(),
                    task_set));
   }
 
-  resource_pool_->CheckBusyResources();
+  resource_pool_->CheckBusyResources(false);
 
   for (RasterTaskQueue::Item::Vector::const_iterator it = queue->items.begin();
        it != queue->items.end();
        ++it) {
     const RasterTaskQueue::Item& item = *it;
     RasterTask* task = item.task;
     DCHECK(!task->HasCompleted());
 
     for (TaskSet task_set = 0; task_set < kNumberOfTaskSets; ++task_set) {
       if (!item.task_sets[task_set])
@@ skipping 53 matching lines @@
   DCHECK_EQ(resource->format(), resource_pool_->resource_format());
   return make_scoped_ptr<RasterBuffer>(
       new RasterBufferImpl(this, resource_provider_, resource_pool_, resource));
 }
 
 void OneCopyRasterWorkerPool::ReleaseBufferForRaster(
     scoped_ptr<RasterBuffer> buffer) {
   // Nothing to do here. RasterBufferImpl destructor cleans up after itself.
 }
 
-CopySequenceNumber OneCopyRasterWorkerPool::ScheduleCopyOnWorkerThread(
+CopySequenceNumber
+OneCopyRasterWorkerPool::PlaybackAndScheduleCopyOnWorkerThread(
     scoped_ptr<ResourceProvider::ScopedWriteLockGpuMemoryBuffer> write_lock,
-    const Resource* src,
-    const Resource* dst) {
+    scoped_ptr<ScopedResource> src,
+    const Resource* dst,
+    const RasterSource* raster_source,
+    const gfx::Rect& rect,
+    float scale,
+    RenderingStatsInstrumentation* stats) {
   CopySequenceNumber sequence;
 
   {
     base::AutoLock lock(lock_);
 
+    int failed_attempts = 0;
+    while ((scheduled_copy_operation_count_ + issued_copy_operation_count_) >=
+           kMaxCopyOperations) {
+      // Ignore limit when shutdown is set.
+      if (shutdown_)
+        break;
+
+      ++failed_attempts;
+
+      // Schedule a check that will also wait for operations to complete
+      // after too many failed attempts.
+      bool wait_if_needed = failed_attempts > kFailedAttemptsBeforeWaitIfNeeded;
+
+      // Schedule a check for completed copy operations if too many operations
+      // are currently in-flight.
+      ScheduleCheckForCompletedCopyOperationsWithLockAcquired(wait_if_needed);
+
+      {
+        TRACE_EVENT0("cc", "WaitingForCopyOperationsToComplete");
+
+        // Wait for in-flight copy operations to drop below limit.
+        copy_operation_count_cv_.Wait();
+      }
+    }
+
+    // Increment |scheduled_copy_operation_count_| before releasing |lock_|.
+    ++scheduled_copy_operation_count_;
+
+    // There may be more work available, so wake up another worker thread.
+    copy_operation_count_cv_.Signal();
+
+    {
+      base::AutoUnlock unlock(lock_);
+
+      gfx::GpuMemoryBuffer* gpu_memory_buffer =
+          write_lock->GetGpuMemoryBuffer();
+      if (gpu_memory_buffer) {
+        RasterWorkerPool::PlaybackToMemory(gpu_memory_buffer->Map(),
+                                           src->format(),
+                                           src->size(),
+                                           gpu_memory_buffer->GetStride(),
+                                           raster_source,
+                                           rect,
+                                           scale,
+                                           stats);
+        gpu_memory_buffer->Unmap();
+      }
+    }
+
+    // Acquire a sequence number for this copy operation.
     sequence = next_copy_operation_sequence_++;
 
-    pending_copy_operations_.push_back(make_scoped_ptr(
-        new CopyOperation(write_lock.Pass(), src->id(), dst->id())));
+    pending_copy_operations_.push_back(
+        make_scoped_ptr(new CopyOperation(write_lock.Pass(), src.Pass(), dst)));
   }
 
   // Post task that will advance last flushed copy operation to |sequence|
   // if we have reached the flush period.
   if ((sequence % kCopyFlushPeriod) == 0) {
     task_runner_->PostTask(
         FROM_HERE,
         base::Bind(&OneCopyRasterWorkerPool::AdvanceLastFlushedCopyTo,
                    weak_ptr_factory_.GetWeakPtr(),
                    sequence));
@@ skipping 44 matching lines @@
 
   CopyOperation::Deque copy_operations;
 
   {
     base::AutoLock lock(lock_);
 
     for (int64 i = 0; i < count; ++i) {
       DCHECK(!pending_copy_operations_.empty());
       copy_operations.push_back(pending_copy_operations_.take_front());
     }
+
+    // Decrement |scheduled_copy_operation_count_| and increment
+    // |issued_copy_operation_count_| to reflect the transition of copy
+    // operations from "pending" to "issued" state.
+    DCHECK_GE(scheduled_copy_operation_count_, copy_operations.size());
+    scheduled_copy_operation_count_ -= copy_operations.size();
+    issued_copy_operation_count_ += copy_operations.size();
   }
 
   while (!copy_operations.empty()) {
     scoped_ptr<CopyOperation> copy_operation = copy_operations.take_front();
 
     // Remove the write lock.
     copy_operation->write_lock.reset();
 
     // Copy contents of source resource to destination resource.
-    resource_provider_->CopyResource(copy_operation->src, copy_operation->dst);
+    resource_provider_->CopyResource(copy_operation->src->id(),
+                                     copy_operation->dst->id());
+
+    // Return source resource to pool where it can be reused once copy
+    // operation has completed and resource is no longer busy.
+    resource_pool_->ReleaseResource(copy_operation->src.Pass());
   }
 }
 
+void OneCopyRasterWorkerPool::
+    ScheduleCheckForCompletedCopyOperationsWithLockAcquired(
+        bool wait_if_needed) {
+  lock_.AssertAcquired();
+
+  if (check_for_completed_copy_operations_pending_)
+    return;
+
+  base::TimeTicks now = base::TimeTicks::Now();
+
+  // Schedule a check for completed copy operations as soon as possible but
+  // don't allow two consecutive checks to be scheduled to run less than the
+  // tick rate apart.
+  base::TimeTicks next_check_for_completed_copy_operations_time =
+      std::max(last_check_for_completed_copy_operations_time_ +
+                   base::TimeDelta::FromMilliseconds(
+                       kCheckForCompletedCopyOperationsTickRateMs),
+               now);
+
+  task_runner_->PostDelayedTask(
+      FROM_HERE,
+      base::Bind(&OneCopyRasterWorkerPool::CheckForCompletedCopyOperations,
+                 weak_ptr_factory_.GetWeakPtr(),
+                 wait_if_needed),
+      next_check_for_completed_copy_operations_time - now);
+
+  last_check_for_completed_copy_operations_time_ =
+      next_check_for_completed_copy_operations_time;
+  check_for_completed_copy_operations_pending_ = true;
+}
+
+void OneCopyRasterWorkerPool::CheckForCompletedCopyOperations(
+    bool wait_if_needed) {
+  TRACE_EVENT1("cc",
+               "OneCopyRasterWorkerPool::CheckForCompletedCopyOperations",
+               "wait_if_needed",
+               wait_if_needed);
+
+  resource_pool_->CheckBusyResources(wait_if_needed);
+
+  {
+    base::AutoLock lock(lock_);
+
+    DCHECK(check_for_completed_copy_operations_pending_);
+    check_for_completed_copy_operations_pending_ = false;
+
+    // The number of busy resources in the pool reflects the number of issued
+    // copy operations that have not yet completed.
+    issued_copy_operation_count_ = resource_pool_->busy_resource_count();
+
+    // There may be work blocked on too many in-flight copy operations, so wake
+    // up a worker thread.
+    copy_operation_count_cv_.Signal();
+  }
+}
+
 scoped_refptr<base::debug::ConvertableToTraceFormat>
 OneCopyRasterWorkerPool::StateAsValue() const {
   scoped_refptr<base::debug::TracedValue> state =
       new base::debug::TracedValue();
 
   state->BeginArray("tasks_pending");
   for (TaskSet task_set = 0; task_set < kNumberOfTaskSets; ++task_set)
     state->AppendBoolean(raster_pending_[task_set]);
   state->EndArray();
   state->BeginDictionary("staging_state");
   StagingStateAsValueInto(state.get());
   state->EndDictionary();
 
   return state;
 }
+
 void OneCopyRasterWorkerPool::StagingStateAsValueInto(
     base::debug::TracedValue* staging_state) const {
   staging_state->SetInteger("staging_resource_count",
                             resource_pool_->total_resource_count());
   staging_state->SetInteger("bytes_used_for_staging_resources",
                             resource_pool_->total_memory_usage_bytes());
   staging_state->SetInteger("pending_copy_count",
                             resource_pool_->total_resource_count() -
                                 resource_pool_->acquired_resource_count());
   staging_state->SetInteger("bytes_pending_copy",
                             resource_pool_->total_memory_usage_bytes() -
                                 resource_pool_->acquired_memory_usage_bytes());
 }
 
 }  // namespace cc