Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Issue 683113003: Revert r24737 "Read object pointer atomically while updating slots" (Closed)

Created:
6 years, 1 month ago by ulan
Modified:
6 years, 1 month ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Revert r24737 "Read object pointer atomically while updating slots" That broke webkit_unit_tests on ARM64. BUG=chromium:427746 LOG=Y R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24955

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M src/heap/mark-compact.cc View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ulan
PTAL. I will reland r24737 with fix after investigation.
6 years, 1 month ago (2014-10-28 16:39:06 UTC) #2
Michael Starzinger
LGTM (rubber-stamped).
6 years, 1 month ago (2014-10-28 16:40:48 UTC) #3
ulan
6 years, 1 month ago (2014-10-28 16:43:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24955 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698