Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 683083004: Re-enable the inspector tests (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
ojan, eseidel
CC:
mojo-reviews_chromium.org, ojan, esprehn, eseidel
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -7 lines) Patch
M sky/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A sky/framework/inspector/BUILD.gn View 1 chunk +24 lines, -0 lines 0 comments Download
A sky/framework/inspector/server/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
M sky/tests/TestExpectations View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/tests/inspector/dom-mutation.sky View 2 chunks +1 line, -2 lines 0 comments Download
M sky/tests/inspector/dom-mutation-modify-text-node-and-append.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tools/webkitpy/layout_tests/servers/apache_http.py View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
abarth-chromium
6 years, 1 month ago (2014-10-28 18:36:11 UTC) #1
eseidel
lgtm
6 years, 1 month ago (2014-10-28 19:34:45 UTC) #4
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
6 years, 1 month ago (2014-10-28 19:35:59 UTC) #6
abarth-chromium
6 years, 1 month ago (2014-10-28 19:54:26 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ff89188285549b11134bbbec2c52ff29406f7b31 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698