Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Issue 683083002: [Extensions] Chromium crashed in single-process mode on fresh launch. (Closed)

Created:
6 years, 1 month ago by Pritam Nikam
Modified:
6 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Chromium crashed in single-process mode on fresh launch. With current implementation, in-process utility thread clean up is taken care by IO thread on detecting that concern IPC communication channel been closed. And utility thread has ThreadRestrictions to disallowed IO. Apparently it asserts (SIG-ABORT) before performing join in pre-check. With this CL we are making sure that before IO thread waits for utility thread's cleanup it enables ThreadRestrictions to allow IO for utility thread so that it can join. This avoids chromium crash on fresh launch. BUG=421007 R=mpcomplete@chromium.org Committed: https://crrev.com/e82a809ff6040ab6a752eef2b97502bfbf9e8108 Cr-Commit-Position: refs/heads/master@{#302112}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/utility/in_process_utility_thread.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Pritam Nikam
Hi Ken, PTAL, Thanks!
6 years, 1 month ago (2014-10-29 06:27:25 UTC) #3
Ken Rockot(use gerrit already)
On 2014/10/29 06:27:25, Pritam Nikam wrote: > Hi Ken, > PTAL, Thanks! I don't think ...
6 years, 1 month ago (2014-10-29 14:04:15 UTC) #4
Pritam Nikam
On 2014/10/29 14:04:15, Ken Rockot wrote: > On 2014/10/29 06:27:25, Pritam Nikam wrote: > > ...
6 years, 1 month ago (2014-10-29 14:32:52 UTC) #5
Pritam Nikam
+ Matt & miket. I encounter this crash (SIG-ABORT) on fresh launch chromium in single ...
6 years, 1 month ago (2014-10-30 08:55:17 UTC) #7
Matt Perry
lgtm
6 years, 1 month ago (2014-10-30 16:26:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/683083002/40001
6 years, 1 month ago (2014-10-30 17:33:25 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:40001)
6 years, 1 month ago (2014-10-30 18:26:00 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 18:26:35 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e82a809ff6040ab6a752eef2b97502bfbf9e8108
Cr-Commit-Position: refs/heads/master@{#302112}

Powered by Google App Engine
This is Rietveld 408576698