Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 683063004: cc: Disallow copy and assign in unique notifiers. (Closed)

Created:
6 years, 1 month ago by vmpstr
Modified:
6 years, 1 month ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Disallow copy and assign in unique notifiers. This patch explicitly prohibits copy and assign for unique notifiers. R=danakj Committed: https://crrev.com/5f135775a098fcc229d8a8c4aa919c3871bf8f40 Cr-Commit-Position: refs/heads/master@{#301718}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M cc/base/delayed_unique_notifier.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/base/unique_notifier.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
vmpstr
PTAL
6 years, 1 month ago (2014-10-28 20:42:03 UTC) #1
danakj
LGTM Does this somehow fix that DCHECK?
6 years, 1 month ago (2014-10-28 20:45:28 UTC) #2
vmpstr
On 2014/10/28 20:45:28, danakj wrote: > LGTM > > Does this somehow fix that DCHECK? ...
6 years, 1 month ago (2014-10-28 20:49:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/683063004/1
6 years, 1 month ago (2014-10-28 20:50:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-28 21:54:21 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 21:55:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f135775a098fcc229d8a8c4aa919c3871bf8f40
Cr-Commit-Position: refs/heads/master@{#301718}

Powered by Google App Engine
This is Rietveld 408576698