Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 683063002: Add DumpAccessibilityTree tests (9 of 20) (Closed)

Created:
6 years, 1 month ago by shreeramk
Modified:
6 years, 1 month ago
Reviewers:
dmazzoni
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add DumpAccessibilityTree tests (9 of 20) HTML Tag: summary, h1 to h6, thead, input-url, fieldset, audio, iframe ARIA role: rowgroup, presentation ARIA state/property: aria-valuemax Other Fixes in this CL: 1. Under switch case AX_ROLE_GROUP only HTML li tag should have STATE_SYSTEM_READONLY 2. Also ROLE_SYSTEM_TABLE, _ROW, _ROWHEADER, _COLUMN, _COLUMNHEADER shouldn't have STATE_SYSTEM_READONLY 2. HTML Iframe tag should have ia_role_ as ROLE_SYSTEM_GROUPING and ia_state_ as STATE_SYSTEM_READONLY BUG=170581 Committed: https://crrev.com/e8234c99de489f9572751188a671ec1fad36817c Cr-Commit-Position: refs/heads/master@{#301806}

Patch Set 1 #

Patch Set 2 : uploading and updating expectations #

Patch Set 3 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+453 lines, -418 lines) Patch
M content/browser/accessibility/browser_accessibility_win.cc View 1 2 8 chunks +3 lines, -12 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 9 chunks +34 lines, -2 lines 0 comments Download
M content/test/data/accessibility/a-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/a-with-img-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/aria-columnheader-expected-win.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
A + content/test/data/accessibility/aria-heading.html View 1 chunk +15 lines, -22 lines 0 comments Download
A + content/test/data/accessibility/aria-heading-expected-android.txt View 1 chunk +7 lines, -13 lines 0 comments Download
A + content/test/data/accessibility/aria-heading-expected-mac.txt View 1 chunk +13 lines, -25 lines 0 comments Download
A content/test/data/accessibility/aria-heading-expected-win.txt View 1 chunk +13 lines, -0 lines 0 comments Download
M content/test/data/accessibility/aria-level-expected-win.txt View 1 1 chunk +8 lines, -8 lines 0 comments Download
A content/test/data/accessibility/aria-presentation.html View 1 chunk +6 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-presentation-expected-android.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-presentation-expected-mac.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-presentation-expected-win.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/data/accessibility/aria-readonly-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/aria-row-expected-win.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
A content/test/data/accessibility/aria-rowgroup.html View 1 chunk +11 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-rowgroup-expected-android.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-rowgroup-expected-mac.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-rowgroup-expected-win.txt View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M content/test/data/accessibility/aria-separator-expected-android.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/aria-separator-expected-mac.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/aria-separator-expected-win.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/data/accessibility/aria-sort-expected-win.txt View 1 1 chunk +12 lines, -12 lines 0 comments Download
M content/test/data/accessibility/aria-tree-expected-win.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/aside-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
A content/test/data/accessibility/audio.html View 1 chunk +12 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/audio-expected-android.txt View 1 chunk +8 lines, -8 lines 0 comments Download
A + content/test/data/accessibility/audio-expected-mac.txt View 1 chunk +11 lines, -11 lines 0 comments Download
A + content/test/data/accessibility/audio-expected-win.txt View 1 chunk +11 lines, -11 lines 0 comments Download
M content/test/data/accessibility/bdo-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/br-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/button-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/button-name-calc-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/canvas-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/caption-expected-win.txt View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M content/test/data/accessibility/checkbox-name-calc-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/cite-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/dfn-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/em-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
A + content/test/data/accessibility/fieldset.html View 1 chunk +12 lines, -17 lines 0 comments Download
A + content/test/data/accessibility/fieldset-expected-android.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
A content/test/data/accessibility/fieldset-expected-mac.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download
A content/test/data/accessibility/fieldset-expected-win.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download
M content/test/data/accessibility/figcaption-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/heading.html View 2 chunks +1 line, -9 lines 0 comments Download
M content/test/data/accessibility/heading-expected-android.txt View 1 chunk +0 lines, -6 lines 0 comments Download
M content/test/data/accessibility/heading-expected-mac.txt View 1 chunk +0 lines, -12 lines 0 comments Download
M content/test/data/accessibility/heading-expected-win.txt View 1 chunk +6 lines, -18 lines 0 comments Download
M content/test/data/accessibility/hr-expected-win.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + content/test/data/accessibility/iframe.html View 1 chunk +10 lines, -10 lines 1 comment Download
M content/test/data/accessibility/iframe-coordinates-expected-win.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + content/test/data/accessibility/iframe-expected-android.txt View 1 1 chunk +5 lines, -4 lines 0 comments Download
A content/test/data/accessibility/iframe-expected-mac.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download
A content/test/data/accessibility/iframe-expected-win.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/iframesrc.html View 1 chunk +5 lines, -7 lines 0 comments Download
M content/test/data/accessibility/img-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/input-button-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/input-button-in-menu-expected-win.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/data/accessibility/input-checkbox-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/input-checkbox-in-menu-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/input-color-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/input-date-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/input-datetime-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/input-datetime-local-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/input-radio-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/input-range-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/input-reset-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/input-search-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/input-tel-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/input-text-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/input-text-name-calc-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/input-time-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/input-types-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
A + content/test/data/accessibility/input-url.html View 1 chunk +10 lines, -11 lines 0 comments Download
A + content/test/data/accessibility/input-url-expected-android.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + content/test/data/accessibility/input-url-expected-mac.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + content/test/data/accessibility/input-url-expected-win.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/data/accessibility/input-week-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/label-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/legend-expected-mac.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/test/data/accessibility/legend-expected-win.txt View 1 1 chunk +4 lines, -3 lines 0 comments Download
M content/test/data/accessibility/modal-dialog-closed-expected-win.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/data/accessibility/modal-dialog-in-iframe-closed-expected-win.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/data/accessibility/modal-dialog-in-iframe-opened-expected-win.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/data/accessibility/object-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/p-expected-win.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/data/accessibility/progress-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
A + content/test/data/accessibility/sfx.mp3 View Binary file 0 comments Download
M content/test/data/accessibility/source.html View 1 chunk +1 line, -1 line 0 comments Download
A + content/test/data/accessibility/summary.html View 1 chunk +12 lines, -17 lines 0 comments Download
A + content/test/data/accessibility/summary-expected-android.txt View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
A content/test/data/accessibility/summary-expected-mac.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/summary-expected-win.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
M content/test/data/accessibility/svg-expected-win.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/data/accessibility/table-simple-expected-win.txt View 1 chunk +20 lines, -0 lines 0 comments Download
M content/test/data/accessibility/table-spans-expected-win.txt View 1 chunk +13 lines, -0 lines 0 comments Download
D content/test/data/accessibility/table-tbody-tfoot.html View 1 chunk +0 lines, -38 lines 0 comments Download
D content/test/data/accessibility/table-tbody-tfoot-expected-android.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D content/test/data/accessibility/table-tbody-tfoot-expected-mac.txt View 1 chunk +0 lines, -25 lines 0 comments Download
D content/test/data/accessibility/table-tbody-tfoot-expected-win.txt View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/accessibility/table-th-rowheader.html View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/data/accessibility/table-th-rowheader-expected-android.txt View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/table-th-rowheader-expected-mac.txt View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/table-th-rowheader-expected-win.txt View 1 chunk +15 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/table-thead-tbody-tfoot.html View 3 chunks +4 lines, -3 lines 0 comments Download
A + content/test/data/accessibility/table-thead-tbody-tfoot-expected-android.txt View 1 chunk +1 line, -1 line 0 comments Download
A + content/test/data/accessibility/table-thead-tbody-tfoot-expected-mac.txt View 1 chunk +1 line, -1 line 0 comments Download
A content/test/data/accessibility/table-thead-tbody-tfoot-expected-win.txt View 1 chunk +26 lines, -0 lines 0 comments Download
M content/test/data/accessibility/textarea-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/transition-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/wbr-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
shreeramk
Please review the changes. Thanks!
6 years, 1 month ago (2014-10-28 19:07:32 UTC) #2
dmazzoni
lgtm https://codereview.chromium.org/683063002/diff/40001/content/test/data/accessibility/iframe.html File content/test/data/accessibility/iframe.html (right): https://codereview.chromium.org/683063002/diff/40001/content/test/data/accessibility/iframe.html#newcode7 content/test/data/accessibility/iframe.html:7: <iframe src="iframesrc.html"> I'm slightly worried that this test ...
6 years, 1 month ago (2014-10-29 07:15:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/683063002/40001
6 years, 1 month ago (2014-10-29 07:15:59 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-10-29 08:03:02 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 08:03:48 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e8234c99de489f9572751188a671ec1fad36817c
Cr-Commit-Position: refs/heads/master@{#301806}

Powered by Google App Engine
This is Rietveld 408576698