Issue 68303004: [oilpan] Move EventHandler to the heap

Issue 68303004: [oilpan] Move EventHandler to the heap (Closed)

Created:
7 years, 1 month ago by haraken

Modified:
7 years, 1 month ago

Reviewers:
zerny-chromium, wibling-chromium, Erik Corry, Vyacheslav Egorov (Chromium), Mads Ager (chromium)

CC:
blink-reviews, adamk+oilpan_chromium.org, Mads Ager (chromium), abarth-chromium

Base URL:
svn://svn.chromium.org/blink/branches/oilpan

Visibility:
Public.

More Reviews

Description

[oilpan] Move EventHandler to the heap R=ager@chromium.org, zerny@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161795

Patch Set 2 : #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -36 lines)			Patch
M	Source/WebKit/chromium/src/ViewportAnchor.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/WebKit/chromium/src/ViewportAnchor.cpp	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/WebKit/chromium/src/WebViewImpl.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/inspector/InspectorInputAgent.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/page/AutoscrollController.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/page/EventHandler.h	View	1	5 chunks	+26 lines, -17 lines	0 comments	Download
M	Source/core/page/EventHandler.cpp	View	1	5 chunks	+23 lines, -4 lines	0 comments	Download
M	Source/core/page/Frame.h	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/page/Frame.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

haraken

PTAL This CL reduces # of Persistents but won't contribute to reducing leaks since this ...

7 years, 1 month ago (2013-11-11 12:40:32 UTC) #1

haraken

https://codereview.chromium.org/68303004/diff/1/Source/core/page/EventHandler.h File Source/core/page/EventHandler.h (right): https://codereview.chromium.org/68303004/diff/1/Source/core/page/EventHandler.h#newcode392 Source/core/page/EventHandler.h:392: typedef CollectionRoot<HashMap<int, Member<EventTarget> > > TouchTargetMap; oh, I forgot ...

7 years, 1 month ago (2013-11-11 12:41:35 UTC) #2

haraken

PTAL https://codereview.chromium.org/68303004/diff/1/Source/core/page/EventHandler.h File Source/core/page/EventHandler.h (right): https://codereview.chromium.org/68303004/diff/1/Source/core/page/EventHandler.h#newcode392 Source/core/page/EventHandler.h:392: typedef CollectionRoot<HashMap<int, Member<EventTarget> > > TouchTargetMap; On 2013/11/11 ...

7 years, 1 month ago (2013-11-11 12:45:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r161795.

Expand Messages | Collapse Messages