Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 683023002: Move AST node counting to post-pass (Closed)

Created:
6 years, 1 month ago by wingo
Modified:
6 years, 1 month ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -66 lines) Patch
M src/ast.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ast.cc View 3 chunks +0 lines, -10 lines 0 comments Download
M src/ast-numbering.cc View 24 chunks +67 lines, -4 lines 0 comments Download
M src/compiler.h View 1 chunk +7 lines, -2 lines 0 comments Download
M src/compiler.cc View 6 chunks +24 lines, -13 lines 1 comment Download
M src/compiler/js-inlining.cc View 2 chunks +3 lines, -12 lines 1 comment Download
M src/full-codegen.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/compiler/function-tester.h View 2 chunks +2 lines, -6 lines 0 comments Download
M test/cctest/compiler/test-codegen-deopt.cc View 1 chunk +1 line, -3 lines 0 comments Download
M test/cctest/compiler/test-pipeline.cc View 1 chunk +1 line, -5 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
wingo
PTAL; this is the patch from yesterday with a couple of modifications mentioned in the ...
6 years, 1 month ago (2014-10-28 08:31:02 UTC) #3
Michael Starzinger
LGTM (mostly rubber-stamped, only reviewed the marked changes).
6 years, 1 month ago (2014-10-28 11:20:21 UTC) #4
wingo
6 years, 1 month ago (2014-10-28 13:24:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as 24937 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698