Extract a DOMWindow interface from LocalDOMWindow and use it in the idl.

Source/core/page/DOMWindowPagePopup.h

Index: Source/core/page/DOMWindowPagePopup.h
diff --git a/Source/core/page/DOMWindowPagePopup.h b/Source/core/page/DOMWindowPagePopup.h
index fb230213aff8c1cd37710f5f58dd3bf03ced12ab..58c673838e5726a07f57503840640c1fce2e6808 100644
--- a/Source/core/page/DOMWindowPagePopup.h
+++ b/Source/core/page/DOMWindowPagePopup.h
@@ -31,19 +31,19 @@
 #ifndef DOMWindowPagePopup_h
 #define DOMWindowPagePopup_h
 
+#include "core/frame/LocalDOMWindow.h"
 #include "platform/Supplementable.h"
 #include "platform/heap/Handle.h"
 
 namespace blink {
 
-class LocalDOMWindow;
 class PagePopupClient;
 class PagePopupController;
 
 class DOMWindowPagePopup final : public NoBaseWillBeGarbageCollected<DOMWindowPagePopup>, public WillBeHeapSupplement<LocalDOMWindow> {
     WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(DOMWindowPagePopup);
 public:
-    static PagePopupController* pagePopupController(LocalDOMWindow&);
+    static PagePopupController* pagePopupController(DOMWindow&);

[dcheng, 2014/10/31 03:20:41]

These changes (and other similar changes in Source/modules) are due to the way
the generated bindings call these methods. They extract the C++ object from the
V8 wrapper object, but since we changed ImplementedAs to DOMWindow, we end up
with something like this:
  DOMWindow& window = *V8Window::toImpl(...);
  ... DOMWindowPagePopup::pagePopupController(window) ...
but this is a compiler error, since we need to downcast from to a
LocalDOMWindow.

While it would be nice for these methods to take a LocalDOMWindow& (since they
will logically never work on a remote DOM window), I don't see any way to do
this without adding special logic in the bindings just to handle this special
DOMWindow/LocalDOMWindow case. That seems very hacky and fragile.

     static void install(LocalDOMWindow&, PagePopupClient*);
     static void uninstall(LocalDOMWindow&);
     DECLARE_EMPTY_VIRTUAL_DESTRUCTOR_WILL_BE_REMOVED(DOMWindowPagePopup);