Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Unified Diff: Source/core/frame/DOMWindowProperty.cpp

Issue 683013002: Extract a DOMWindow interface from LocalDOMWindow and use it in the idl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: whee Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/DOMWindowProperty.cpp
diff --git a/Source/core/frame/DOMWindowProperty.cpp b/Source/core/frame/DOMWindowProperty.cpp
index e4664f3a25a7eba380a7200a94abf4add7c0a4e2..20b458d6718938b85f05eb6c9823ef8d36b2469b 100644
--- a/Source/core/frame/DOMWindowProperty.cpp
+++ b/Source/core/frame/DOMWindowProperty.cpp
@@ -42,10 +42,12 @@ DOMWindowProperty::DOMWindowProperty(LocalFrame* frame)
// See fast/dom/navigator-detached-no-crash.html for the recipe.
// We should fix that. <rdar://problem/11567132>
if (m_frame) {
+ // FIXME: Need to figure out what to do with DOMWindowProperties on
+ // remote DOM windows.
dcheng 2014/10/31 03:20:41 The only DOMWindowProperty this really affects is
#if ENABLE(OILPAN)
- m_frame->domWindow()->registerProperty(this);
+ m_frame->localDOMWindow()->registerProperty(this);
#else
- m_associatedDOMWindow = m_frame->domWindow();
+ m_associatedDOMWindow = m_frame->localDOMWindow();
haraken 2014/10/31 06:07:04 Rename m_associatedDOMWindow to m_associatedLocalD
m_associatedDOMWindow->registerProperty(this);
#endif
}

Powered by Google App Engine
This is Rietveld 408576698