Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: Source/bindings/core/v8/custom/V8EventTargetCustom.cpp

Issue 683013002: Extract a DOMWindow interface from LocalDOMWindow and use it in the idl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: whee Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/custom/V8EventTargetCustom.cpp
diff --git a/Source/bindings/core/v8/custom/V8EventTargetCustom.cpp b/Source/bindings/core/v8/custom/V8EventTargetCustom.cpp
index e360061a0b6376c0d59473aca8f1317708872254..4b048fa1b38c356fa30af5c475e12edf33a6cb22 100644
--- a/Source/bindings/core/v8/custom/V8EventTargetCustom.cpp
+++ b/Source/bindings/core/v8/custom/V8EventTargetCustom.cpp
@@ -41,8 +41,9 @@ v8::Handle<v8::Value> toV8(EventTarget* impl, v8::Handle<v8::Object> creationCon
if (UNLIKELY(!impl))
return v8::Null(isolate);
+ // FIXME: This naming seems broken.
if (impl->interfaceName() == EventTargetNames::LocalDOMWindow)
dcheng 2014/10/31 03:20:40 I'm not really sure what this is used for. It seem
haraken 2014/10/31 06:07:04 Yeah, let's fix this in a follow-up CL.
- return toV8(static_cast<LocalDOMWindow*>(impl), creationContext, isolate);
+ return toV8(static_cast<DOMWindow*>(impl), creationContext, isolate);
v8::Handle<v8::Value> wrapper = DOMDataStore::getWrapperNonTemplate(impl, isolate);
if (!wrapper.IsEmpty())

Powered by Google App Engine
This is Rietveld 408576698