Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: Source/bindings/core/v8/BindingSecurity.cpp

Issue 683013002: Extract a DOMWindow interface from LocalDOMWindow and use it in the idl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: whee Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/BindingSecurity.cpp
diff --git a/Source/bindings/core/v8/BindingSecurity.cpp b/Source/bindings/core/v8/BindingSecurity.cpp
index f3cb1164c7db70100bbca238c5739766269415ea..61c8742b83008cd4bedacf1fd2bc8b86848c9d37 100644
--- a/Source/bindings/core/v8/BindingSecurity.cpp
+++ b/Source/bindings/core/v8/BindingSecurity.cpp
@@ -72,9 +72,10 @@ static bool canAccessDocument(v8::Isolate* isolate, Document* targetDocument, Se
if (isDocumentAccessibleFromDOMWindow(targetDocument, callingWindow))
return true;
+ // FIXME: This logic looks unnecessarily convoluted.
if (reportingOption == ReportSecurityError && targetDocument->domWindow()) {
if (LocalFrame* frame = targetDocument->frame())
- frame->domWindow()->printErrorMessage(targetDocument->domWindow()->crossDomainAccessErrorMessage(callingWindow));
+ frame->localDOMWindow()->printErrorMessage(targetDocument->domWindow()->crossDomainAccessErrorMessage(callingWindow));
}
return false;
« no previous file with comments | « no previous file | Source/bindings/core/v8/DictionaryHelperForCore.cpp » ('j') | Source/bindings/core/v8/ScriptState.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698