Source/bindings/core/v8/custom/V8InspectorFrontendHostCustom.cpp - Issue 683013002: Extract a DOMWindow interface from LocalDOMWindow and use it in the idl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/custom/V8InspectorFrontendHostCustom.cpp

Issue 683013002: Extract a DOMWindow interface from LocalDOMWindow and use it in the idl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase on top of DOMWindow moves and UseCounter overload for Frame Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/custom/V8InspectorFrontendHostCustom.cpp

diff --git a/Source/bindings/core/v8/custom/V8InspectorFrontendHostCustom.cpp b/Source/bindings/core/v8/custom/V8InspectorFrontendHostCustom.cpp

index 84c513f0d92c2c3b397ce764fff1d1139cefb0e7..1ab8fc3f409f9de36433126c96b2751a5b1052b1 100644

--- a/Source/bindings/core/v8/custom/V8InspectorFrontendHostCustom.cpp

+++ b/Source/bindings/core/v8/custom/V8InspectorFrontendHostCustom.cpp

@@ -158,8 +158,8 @@ void V8InspectorFrontendHost::showContextMenuAtPointMethodCustom(const v8::Funct

v8::Handle<v8::Object> windowWrapper = V8Window::findInstanceInPrototypeChain(isolate->GetEnteredContext()->Global(), isolate);

if (windowWrapper.IsEmpty())

return;

- LocalDOMWindow* window = V8Window::toImpl(windowWrapper);

- document = window ? window->document() : nullptr;

+ DOMWindow* window = V8Window::toImpl(windowWrapper);

+ document = window ? toLocalDOMWindow(window)->document() : nullptr;

}

if (!document || !document->page())

return;