Source/modules/filesystem/DOMWindowFileSystem.cpp - Issue 683013002: Extract a DOMWindow interface from LocalDOMWindow and use it in the idl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/filesystem/DOMWindowFileSystem.cpp

Issue 683013002: Extract a DOMWindow interface from LocalDOMWindow and use it in the idl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix incorrect assumption Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/crypto/DOMWindowCrypto.cpp ('K') | « Source/modules/filesystem/DOMWindowFileSystem.h ('k') | Source/modules/gamepad/NavigatorGamepad.cpp » ('j') | Source/modules/indexeddb/DOMWindowIndexedDatabase.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/filesystem/DOMWindowFileSystem.cpp

diff --git a/Source/modules/filesystem/DOMWindowFileSystem.cpp b/Source/modules/filesystem/DOMWindowFileSystem.cpp

index bc491298ed92293432d863f2d7c98bd8f0a79233..cdc1617416ec47ee77afb26bb82f03077acc7e69 100644

--- a/Source/modules/filesystem/DOMWindowFileSystem.cpp

+++ b/Source/modules/filesystem/DOMWindowFileSystem.cpp

@@ -48,8 +48,9 @@ DOMWindowFileSystem::~DOMWindowFileSystem()

{

}

-void DOMWindowFileSystem::webkitRequestFileSystem(LocalDOMWindow& window, int type, long long size, FileSystemCallback* successCallback, ErrorCallback* errorCallback)

+void DOMWindowFileSystem::webkitRequestFileSystem(DOMWindow& windowArg, int type, long long size, FileSystemCallback* successCallback, ErrorCallback* errorCallback)

haraken 2014/11/08 09:17:25 Ditto.

{

+ LocalDOMWindow& window = toLocalDOMWindow(windowArg);

if (!window.isCurrentlyDisplayedInFrame())

return;

@@ -71,8 +72,9 @@ void DOMWindowFileSystem::webkitRequestFileSystem(LocalDOMWindow& window, int ty

LocalFileSystem::from(*document)->requestFileSystem(document, fileSystemType, size, FileSystemCallbacks::create(successCallback, errorCallback, document, fileSystemType));

}

-void DOMWindowFileSystem::webkitResolveLocalFileSystemURL(LocalDOMWindow& window, const String& url, EntryCallback* successCallback, ErrorCallback* errorCallback)

+void DOMWindowFileSystem::webkitResolveLocalFileSystemURL(DOMWindow& windowArg, const String& url, EntryCallback* successCallback, ErrorCallback* errorCallback)

haraken 2014/11/08 09:17:25 Ditto.

{

+ LocalDOMWindow& window = toLocalDOMWindow(windowArg);

if (!window.isCurrentlyDisplayedInFrame())

return;