Source/core/page/CreateWindow.cpp - Issue 683013002: Extract a DOMWindow interface from LocalDOMWindow and use it in the idl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/CreateWindow.cpp

Issue 683013002: Extract a DOMWindow interface from LocalDOMWindow and use it in the idl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix incorrect assumption Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/page/CreateWindow.cpp

diff --git a/Source/core/page/CreateWindow.cpp b/Source/core/page/CreateWindow.cpp

index 50f4cddeac9d5dcf5ded92a55ffde4b9c99bd8bf..822dd26fdf27f0b11f00705ec23652a918c69c78 100644

--- a/Source/core/page/CreateWindow.cpp

+++ b/Source/core/page/CreateWindow.cpp

@@ -149,11 +149,11 @@ LocalFrame* createWindow(const String& urlString, const AtomicString& frameName,

newFrame->loader().setOpener(&openerFrame);

- if (newFrame->domWindow()->isInsecureScriptAccess(callingWindow, completedURL))

+ if (newFrame->localDOMWindow()->isInsecureScriptAccess(callingWindow, completedURL))

return newFrame;

if (function)

- function(newFrame->domWindow(), functionContext);

+ function(newFrame->localDOMWindow(), functionContext);

if (created)

newFrame->loader().load(FrameLoadRequest(callingWindow.document(), completedURL));