Source/bindings/core/v8/custom/V8EventTargetCustom.cpp - Issue 683013002: Extract a DOMWindow interface from LocalDOMWindow and use it in the idl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/custom/V8EventTargetCustom.cpp

Issue 683013002: Extract a DOMWindow interface from LocalDOMWindow and use it in the idl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix incorrect assumption Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/custom/V8EventTargetCustom.cpp

diff --git a/Source/bindings/core/v8/custom/V8EventTargetCustom.cpp b/Source/bindings/core/v8/custom/V8EventTargetCustom.cpp

index e360061a0b6376c0d59473aca8f1317708872254..4b048fa1b38c356fa30af5c475e12edf33a6cb22 100644

--- a/Source/bindings/core/v8/custom/V8EventTargetCustom.cpp

+++ b/Source/bindings/core/v8/custom/V8EventTargetCustom.cpp

@@ -41,8 +41,9 @@ v8::Handle<v8::Value> toV8(EventTarget* impl, v8::Handle<v8::Object> creationCon

if (UNLIKELY(!impl))

return v8::Null(isolate);

+ // FIXME: This naming seems broken.

if (impl->interfaceName() == EventTargetNames::LocalDOMWindow)

- return toV8(static_cast<LocalDOMWindow*>(impl), creationContext, isolate);

+ return toV8(static_cast<DOMWindow*>(impl), creationContext, isolate);

v8::Handle<v8::Value> wrapper = DOMDataStore::getWrapperNonTemplate(impl, isolate);

if (!wrapper.IsEmpty())