Extract a DOMWindow interface from LocalDOMWindow and use it in the idl.

Source/core/frame/LocalFrame.h

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999-2001 Lars Knoll <knoll@kde.org>
  *                     1999-2001 Antti Koivisto <koivisto@kde.org>
  *                     2000-2001 Simon Hausmann <hausmann@kde.org>
  *                     2000-2001 Dirk Mueller <mueller@kde.org>
  *                     2000 Stefan Schimanski <1Stein@gmx.de>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
@@ skipping 37 matching lines @@
     class FetchContext;
     class FloatSize;
     class FrameConsole;
     class FrameDestructionObserver;
     class FrameSelection;
     class FrameView;
     class HTMLPlugInElement;
     class InputMethodController;
     class IntPoint;
     class IntSize;
+    class LocalDOMWindow;
     class Node;
     class Range;
     class RenderView;
     class TreeScope;
     class ScriptController;
     class SpellChecker;
     class TreeScope;
     class VisiblePosition;
 
     class LocalFrame : public Frame, public WillBeHeapSupplementable<LocalFrame> {
         WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(LocalFrame);
     public:
         static PassRefPtrWillBeRawPtr<LocalFrame> create(FrameLoaderClient*, FrameHost*, FrameOwner*);
 
         void init();
         void setView(PassRefPtrWillBeRawPtr<FrameView>);
         void createView(const IntSize&, const Color&, bool,
             ScrollbarMode = ScrollbarAuto, bool horizontalLock = false,
             ScrollbarMode = ScrollbarAuto, bool verticalLock = false);
 
         // Frame overrides:
         virtual ~LocalFrame();
         virtual void trace(Visitor*) override;
         virtual bool isLocalFrame() const override { return true; }
-        virtual LocalDOMWindow* domWindow() const override;
+        virtual DOMWindow* domWindow() const override;

[dcheng, 2014/10/31 03:20:41]

I wanted to make keep this as a covariant return, but this leads to a circular
dependency between LocalFrame and LocalDOMWindow, since covariant return types
are only legal if a type is a subclass of the base class method's return type.
Since you can't forward declare an inheritance relationship, that means either
LocalFrame or LocalDOMWindow can't use a covariant return. Since there are a lot
less dependencies on LocalFrame::domWindow() returning a LocalDOMWindow, I chose
to change this one instead.

         virtual void navigate(Document& originDocument, const KURL&, bool lockBackForwardList) override;
         virtual void detach() override;
         virtual void disconnectOwnerElement() override;
 
         void addDestructionObserver(FrameDestructionObserver*);
         void removeDestructionObserver(FrameDestructionObserver*);
 
         void willDetachFrameHost();
 
+        LocalDOMWindow* localDOMWindow() const;
         void setDOMWindow(PassRefPtrWillBeRawPtr<LocalDOMWindow>);
         FrameView* view() const;
         Document* document() const;
         void setPagePopupOwner(Element&);
         Element* pagePopupOwner() const { return m_pagePopupOwner.get(); }
 
         RenderView* contentRenderer() const; // Root of the render tree for the document contained in this frame.
 
         Editor& editor() const;
         EventHandler& eventHandler() const;
@@ skipping 108 matching lines @@
         float m_textZoomFactor;
 
         bool m_inViewSourceMode;
     };
 
     inline void LocalFrame::init()
     {
         m_loader.init();
     }
 
+    inline LocalDOMWindow* LocalFrame::localDOMWindow() const
+    {
+        return m_domWindow.get();

[haraken, 2014/10/31 06:07:04]

m_domWindow => m_localDOMWindow

+    }
+
     inline FrameLoader& LocalFrame::loader() const
     {
         return m_loader;
     }
 
     inline NavigationScheduler& LocalFrame::navigationScheduler() const
     {
         return m_navigationScheduler;
     }
 
@@ skipping 51 matching lines @@
     DEFINE_TYPE_CASTS(LocalFrame, Frame, localFrame, localFrame->isLocalFrame(), localFrame.isLocalFrame());
 
 } // namespace blink
 
 // During refactoring, there are some places where we need to do type conversions that
 // will not be needed once all instances of LocalFrame and RemoteFrame are sorted out.
 // At that time this #define will be removed and all the uses of it will need to be corrected.
 #define toLocalFrameTemporary toLocalFrame
 
 #endif // LocalFrame_h