Extract a DOMWindow interface from LocalDOMWindow and use it in the idl.

Source/bindings/core/v8/custom/V8InspectorFrontendHostCustom.cpp

 /*
  * Copyright (C) 2007-2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 140 matching lines @@
     if (info.Length() >= 4) {
         v8::Local<v8::Object> documentWrapper = v8::Local<v8::Object>::Cast(info[3]);
         if (!V8HTMLDocument::wrapperTypeInfo.equals(toWrapperTypeInfo(documentWrapper)))
             return;
         document = V8HTMLDocument::toImpl(documentWrapper);
     } else {
         v8::Isolate* isolate = info.GetIsolate();
         v8::Handle<v8::Object> windowWrapper = V8Window::findInstanceInPrototypeChain(isolate->GetEnteredContext()->Global(), isolate);
         if (windowWrapper.IsEmpty())
             return;
-        LocalDOMWindow* window = V8Window::toImpl(windowWrapper);
-        document = window ? window->document() : nullptr;
+        DOMWindow* window = V8Window::toImpl(windowWrapper);
+        document = window ? toLocalDOMWindow(window)->document() : nullptr;

[haraken, 2014/10/31 06:07:04]

Shouldn't this be:

  document = window->isLocalDOMWindow() ? toLocalDOMWindow(window)->document() :
nullptr;

?

[dcheng, 2014/10/31 06:31:01]

See my previous comment. This code should only ever run in the "right" renderer,
so we should never have to handle a non-LocalDOMWindow here. That is probably
not the case today, but that's why I prefer an explicit crash in
--site-per-process mode: this helps us keep track of problematic areas.

     }
     if (!document || !document->page())
         return;
 
     InspectorFrontendHost* frontendHost = V8InspectorFrontendHost::toImpl(info.Holder());
     Vector<ContextMenuItem> items = menu.items();
     frontendHost->showContextMenu(document->page(), static_cast<float>(x->NumberValue()), static_cast<float>(y->NumberValue()), items);
 }
 
 static void histogramEnumeration(const char* name, const v8::FunctionCallbackInfo<v8::Value>& info, int boundaryValue)
@@ skipping 11 matching lines @@
     histogramEnumeration("DevTools.ActionTaken", info, 100);
 }
 
 void V8InspectorFrontendHost::recordPanelShownMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
     histogramEnumeration("DevTools.PanelShown", info, 20);
 }
 
 } // namespace blink