Source/bindings/core/v8/V8NPObject.h - Issue 683003002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8NPObject.h

Issue 683003002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/V8NPObject.h

diff --git a/Source/bindings/core/v8/V8NPObject.h b/Source/bindings/core/v8/V8NPObject.h

index a0c4423152dc8e1f94a23bd74740804599586464..b72b84cf48d1211a08dfb0910d56eba1d1afb203 100644

--- a/Source/bindings/core/v8/V8NPObject.h

+++ b/Source/bindings/core/v8/V8NPObject.h

@@ -55,7 +55,7 @@ void npObjectInvokeDefaultHandler(const v8::FunctionCallbackInfo<v8::Value>&);

// Get a wrapper for a NPObject.

// If the object is already wrapped, the pre-existing wrapper will be returned. If the object is not wrapped, wrap it, and

// give V8 a weak reference to the wrapper which will cleanup when there are no more JS references to the object.

-v8::Local<v8::Object> createV8ObjectForNPObject(NPObject*, NPObject* root, v8::Isolate*);

+v8::Local<v8::Object> createV8ObjectForNPObject(v8::Isolate*, NPObject*, NPObject* root);

// Tell V8 to forcibly remove an object.

// This is used at plugin teardown so that the caller can aggressively unload the plugin library. After calling this

« no previous file with comments | « Source/bindings/core/v8/V8GCController.cpp ('k') | Source/bindings/core/v8/V8NPObject.cpp » ('j') | no next file with comments »