Source/bindings/core/v8/V8GCController.h - Issue 683003002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8GCController.h

Issue 683003002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/V8GCController.h

diff --git a/Source/bindings/core/v8/V8GCController.h b/Source/bindings/core/v8/V8GCController.h

index 56fdda5548ed39f704c3db7a4e3981deada4ad89..2ee79f038ea7a52415653272015da7d455f0dba6 100644

--- a/Source/bindings/core/v8/V8GCController.h

+++ b/Source/bindings/core/v8/V8GCController.h

@@ -44,7 +44,7 @@ public:

static void gcEpilogue(v8::GCType, v8::GCCallbackFlags);

static void minorGCPrologue(v8::Isolate*);

static void minorGCEpilogue(v8::Isolate*);

- static void majorGCPrologue(bool constructRetainedObjectInfos, v8::Isolate*);

+ static void majorGCPrologue(v8::Isolate*, bool constructRetainedObjectInfos);

static void majorGCEpilogue(v8::Isolate*);

static void collectGarbage(v8::Isolate*);

« no previous file with comments | « Source/bindings/core/v8/V8DOMConfiguration.cpp ('k') | Source/bindings/core/v8/V8GCController.cpp » ('j') | no next file with comments »