runtime/vm/flow_graph_optimizer.cc - Issue 682993008: Improve precision of range analysis by allowing it to track ranges across all int typed phis.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 682993008: Improve precision of range analysis by allowing it to track ranges across all int typed phis. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_optimizer.cc

diff --git a/runtime/vm/flow_graph_optimizer.cc b/runtime/vm/flow_graph_optimizer.cc

index 00112dfa88421110d98c9dcde84191982e376bf4..9cedab65a54107586eec149848ec03778a56e011 100644

--- a/runtime/vm/flow_graph_optimizer.cc

+++ b/runtime/vm/flow_graph_optimizer.cc

@@ -4862,6 +4862,7 @@ void FlowGraphOptimizer::WidenSmiToInt32() {

smi_op->ReplaceWith(int32_op, NULL);

} else if (defn->IsPhi()) {

defn->AsPhi()->set_representation(kUnboxedInt32);

+ ASSERT(defn->Type()->IsInt());

}

« no previous file with comments | « no previous file | runtime/vm/flow_graph_range_analysis.h » ('j') | runtime/vm/flow_graph_range_analysis.cc » ('J')