Add a wrapper for ChromeOS to call into telemetry.

Add a wrapper for ChromeOS to call into telemetry.

R=dtu@chromium.org, achuith@chromium.org
BUG=402172, 388256
Committed: https://crrev.com/c119b2a9a2f586ff478b30e55215df27a2506a97
Cr-Commit-Position: refs/heads/master@{#301557}

[Dirk Pranke, 2014-10-28 01:35:39]

Hi Achuith,

I think that with this wrapper, your telemetry_UnitTests.py becomes just

% cat telemetry_UnitTests.py
# Copyright (c) 2013 The Chromium OS Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

from autotest_lib.client.bin import test
from autotest_lib.client.common_lib import error

from telemetry.unittest import run_chromeos_tests


class telemetry_UnitTests(test.test):
    """This is a client side wrapper for the Telemetry unit tests."""
    version = 1

    def run_once(self, browser_type, unit_tests, perf_tests):
        error_str = run_chromeos_tests.RunTestsForChromeOS(browser_type,
                                                           unit_tests, 
                                                           perf_tests)
        if error_str:
            raise error.TestFail(error_str)
%

If this looks all about right to you, then we can land this change, update the
chromeos-side code, and then land the change switching telemetry to use TYP.

Does that sound about right?

[Dirk Pranke, 2014-10-28 01:35:50]

Patchset #1 (id:1) has been deleted

[achuithb, 2014-10-28 01:43:31]

lgtm

https://codereview.chromium.org/682953002/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/unittest/run_chromeos_tests.py (right):

https://codereview.chromium.org/682953002/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/unittest/run_chromeos_tests.py:35: top_level_dir =
os.path.join(util.GetChromiumSrcDir(), 'tools', root_dir)
I think this should work, but not sure.

Besides this, and getting rid of TestSpec, has anything else changed from the
source script?

[achuithb, 2014-10-28 01:44:35]

Let's land this tonight, hopefully get it into the cros build tonight, and I can
land the cros part of this tomorrow.

[Dirk Pranke, 2014-10-28 01:52:30]

On 2014/10/28 01:43:31, achuithb wrote:
> lgtm
> 
>
https://codereview.chromium.org/682953002/diff/20001/tools/telemetry/telemetr...
> File tools/telemetry/telemetry/unittest/run_chromeos_tests.py (right):
> 
>
https://codereview.chromium.org/682953002/diff/20001/tools/telemetry/telemetr...
> tools/telemetry/telemetry/unittest/run_chromeos_tests.py:35: top_level_dir =
> os.path.join(util.GetChromiumSrcDir(), 'tools', root_dir)
> I think this should work, but not sure.

Yeah, I think this should work as well.

> 
> Besides this, and getting rid of TestSpec, has anything else changed from the
> source script?

Nope (at least, not intentionally).

[Dirk Pranke, 2014-10-28 01:55:22]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2014-10-28 01:57:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/682953002/20001

[commit-bot: I haz the power, 2014-10-28 02:52:10]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2014-10-28 02:52:58]

Patchset 1 (id:??) landed as
https://crrev.com/c119b2a9a2f586ff478b30e55215df27a2506a97
Cr-Commit-Position: refs/heads/master@{#301557}