Make chrome/browser/chromeos/accessibility compile on Athena with use_ash=0

Make chrome/browser/chromeos/accessibility compile on Athena with use_ash=0

This CL:
- Moves the constants in magnifier_constants.h and accessibility_delegate.h
  to ui/chromeos/accessibility_types.
- Stops compiling MagnificationManager on Athena

BUG=426561, 408733
TEST=None

Committed: https://crrev.com/0991c82d09351fa95d96a5ed7cb1082e33daea5b
Cr-Commit-Position: refs/heads/master@{#302218}

[pkotwicz, 2014-10-28 01:17:06]

Patchset #1 (id:1) has been deleted

[pkotwicz, 2014-10-28 01:21:28]

pkotwicz@chromium.org changed reviewers:
+ oshima@chromium.org

[pkotwicz, 2014-10-28 01:21:30]

Oshima, PTAL

https://codereview.chromium.org/682943002/diff/20001/chrome/browser/ui/ash/ch...
File chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc (right):

https://codereview.chromium.org/682943002/diff/20001/chrome/browser/ui/ash/ch...
chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc:69: #if
!defined(USE_ATHENA)
This entire file should not compile on Athena. However, there is quite a bit of
work in order to get it to not compile.

I promise, I will get rid of all of the Athena ifdefs in Ash code once Athena no
longer compiles Ash

[oshima, 2014-10-28 07:53:29]

can you add 408733 to BUG= list?

The number of ifdef worries me, but am fine for now.

https://codereview.chromium.org/682943002/diff/20001/ui/chromeos/accessibilit...
File ui/chromeos/accessibility_types.h (right):

https://codereview.chromium.org/682943002/diff/20001/ui/chromeos/accessibilit...
ui/chromeos/accessibility_types.h:6: #define UI_CHROMEOS_ACCESSIBILITY_TYPES_H_
+dmazzoni@, is this the right place to put this? Let us know what you think.

https://codereview.chromium.org/682943002/diff/20001/ui/chromeos/ui_chromeos.gyp
File ui/chromeos/ui_chromeos.gyp (right):

https://codereview.chromium.org/682943002/diff/20001/ui/chromeos/ui_chromeos....
ui/chromeos/ui_chromeos.gyp:64: 
remove extra new line

[oshima, 2014-10-28 07:54:12]

oshima@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[oshima, 2014-10-28 07:54:13]

+dmazzoni@ 

see my comment in accessibility_types.h

[dmazzoni, 2014-10-28 21:31:42]

https://codereview.chromium.org/682943002/diff/20001/ui/chromeos/accessibilit...
File ui/chromeos/accessibility_types.h (right):

https://codereview.chromium.org/682943002/diff/20001/ui/chromeos/accessibilit...
ui/chromeos/accessibility_types.h:6: #define UI_CHROMEOS_ACCESSIBILITY_TYPES_H_
On 2014/10/28 07:53:28, oshima wrote:
> +dmazzoni@, is this the right place to put this? Let us know what you think.

Yes, I think this makes sense.

[pkotwicz, 2014-10-29 01:04:43]

Oshima can you please take another look?

[oshima, 2014-10-29 01:16:23]

lgtm

[pkotwicz, 2014-10-29 01:55:54]

pkotwicz@chromium.org changed reviewers:
+ sky@chromium.org

[pkotwicz, 2014-10-29 01:55:56]

sky@ for chrome/browser/apps
         chrome/browser/policy
         chrome/browser/resources
         chrome/browser/ui/webui
         ui
OWNERS rubberstamp.

[sky, 2014-10-29 03:45:46]

LGTM

[pkotwicz, 2014-10-29 17:58:09]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-10-29 17:59:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/682943002/60001

[commit-bot: I haz the power, 2014-10-29 18:54:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-29 18:54:42]

Try jobs failed on following builders:
  linux_chromium_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pkotwicz, 2014-10-29 19:25:00]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-10-29 19:25:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/682943002/60001

[commit-bot: I haz the power, 2014-10-29 19:32:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-29 19:32:17]

Try jobs failed on following builders:
  linux_chromium_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pkotwicz, 2014-10-30 16:49:30]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-10-30 16:51:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/682943002/80001

[commit-bot: I haz the power, 2014-10-30 16:56:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-30 16:56:14]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32 on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_x64_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[pkotwicz, 2014-10-30 17:22:44]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-10-30 17:24:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/682943002/100001

[commit-bot: I haz the power, 2014-10-30 17:44:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-30 17:44:55]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pkotwicz, 2014-10-30 18:24:12]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-10-30 18:26:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/682943002/120001

[commit-bot: I haz the power, 2014-10-30 18:43:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-30 18:44:00]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  linux_chromium_chromeos_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pkotwicz, 2014-10-30 20:28:51]

Patchset #7 (id:140001) has been deleted

[pkotwicz, 2014-10-30 20:29:39]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-10-30 20:31:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/682943002/160001

[commit-bot: I haz the power, 2014-10-30 20:37:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-30 20:37:30]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/75994)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[pkotwicz, 2014-10-30 20:45:43]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-10-30 20:46:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/682943002/180001

[commit-bot: I haz the power, 2014-10-30 21:01:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-30 21:01:52]

Try jobs failed on following builders:
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pkotwicz, 2014-10-30 21:05:42]

Patchset #8 (id:180001) has been deleted

[pkotwicz, 2014-10-30 21:06:13]

Patchset #7 (id:160001) has been deleted

[pkotwicz, 2014-10-30 21:06:24]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-10-30 21:07:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/682943002/200001

[commit-bot: I haz the power, 2014-10-31 04:21:12]

Committed patchset #7 (id:200001)

[commit-bot: I haz the power, 2014-10-31 04:21:48]

Patchset 7 (id:??) landed as
https://crrev.com/0991c82d09351fa95d96a5ed7cb1082e33daea5b
Cr-Commit-Position: refs/heads/master@{#302218}