Issue 682913002: Don't crash when importing a 404

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 682913002: Don't crash when importing a 404 (Closed)

Created:
6 years, 1 month ago by abarth-chromium

Modified:
6 years, 1 month ago

Reviewers:
esprehn

CC:
esprehn, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -2 lines)			Patch
M	sky/engine/bindings/core/v8/ScriptController.cpp	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	sky/engine/core/html/imports/HTMLImportLoader.cpp	View	1 chunk	+4 lines, -2 lines	0 comments	Download
A	sky/tests/modules/imports-can-load-404s.html	View	1 chunk	+9 lines, -0 lines	0 comments	Download
A +	sky/tests/modules/imports-can-load-404s-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

6 years, 1 month ago (2014-10-28 00:23:00 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c2611d86060e399eddfad5a064c967543ea34ea4 (presubmit successful).