Remove unnecessary libXss dependency via //build/config/linux:x11

Remove unnecessary libXss dependency via //build/config/linux:x11

It's unnecessary to add the libXss dependency for any target that
depends on //build/config/linux:x11. Instead, the libXss dependency
should be pulled in explicitly via //build/config/linux:xscrnsaver.
This change makes the GN flow more in line with the GYP flow, especially
when building for Chrome OS.

BUG=427726
TEST=Manually test Linux build.
TEST=Manually verify that the libXss dependency is not added when building for Chrome OS with 'os="chromeos"'

Committed: https://crrev.com/407ead664abeab9534ceee416ef637de13c4e247
Cr-Commit-Position: refs/heads/master@{#301802}

[Ben Chan, 2014-10-28 00:03:00]

benchan@chromium.org changed reviewers:
+ brettw@chromium.org, jamesr@chromium.org

[jamesr, 2014-10-28 00:18:05]

Are you sure that every target on non-chromeos that uses Xss declares a
dependency on it?  Why do I not see any try jobs on this patch?

https://codereview.chromium.org/682893003/diff/1/build/config/linux/BUILD.gn
File build/config/linux/BUILD.gn (right):

https://codereview.chromium.org/682893003/diff/1/build/config/linux/BUILD.gn#...
build/config/linux/BUILD.gn:71: # Don't bother running pkg-config for these X
related libraries since it just
hmm, the comment here seems like a lie given that we do have explicit separate
pkg-config targets for many of these libs. could you update it please?

[Ben Chan, 2014-10-28 00:26:40]

On 2014/10/28 00:18:05, jamesr wrote:
> Are you sure that every target on non-chromeos that uses Xss declares a
> dependency on it?  Why do I not see any try jobs on this patch?
> 
> https://codereview.chromium.org/682893003/diff/1/build/config/linux/BUILD.gn
> File build/config/linux/BUILD.gn (right):
> 
>
https://codereview.chromium.org/682893003/diff/1/build/config/linux/BUILD.gn#...
> build/config/linux/BUILD.gn:71: # Don't bother running pkg-config for these X
> related libraries since it just
> hmm, the comment here seems like a lie given that we do have explicit separate
> pkg-config targets for many of these libs. could you update it please?

IIUC, only chrome/browser depends on Xss. chrome/browser/BUILD.gn adds the
dependency on //build/config/linux:xscrnsaver when use_x11=true && !is_chromeos

[jamesr, 2014-10-28 00:28:43]

OK cool, could you try to fix up the comment then?  I think we'll be good to go
then but the current comment is misleading as your patch demonstrates.

[Ben Chan, 2014-10-28 00:32:00]

https://codereview.chromium.org/682893003/diff/1/build/config/linux/BUILD.gn
File build/config/linux/BUILD.gn (right):

https://codereview.chromium.org/682893003/diff/1/build/config/linux/BUILD.gn#...
build/config/linux/BUILD.gn:71: # Don't bother running pkg-config for these X
related libraries since it just
On 2014/10/28 00:18:05, jamesr wrote:
> hmm, the comment here seems like a lie given that we do have explicit separate
> pkg-config targets for many of these libs. could you update it please?

Sorry, I'm not familiar with this 'x11' dependency. Do you mean simply removing
the comment?

I'm also a bit confused by this 'x11' dependency, which seems to include a lot
of dependencies when we also have separate dependency for xcomposite, xext, etc.

[Ben Chan, 2014-10-28 17:41:53]

On 2014/10/28 00:32:00, Ben Chan wrote:
> https://codereview.chromium.org/682893003/diff/1/build/config/linux/BUILD.gn
> File build/config/linux/BUILD.gn (right):
> 
>
https://codereview.chromium.org/682893003/diff/1/build/config/linux/BUILD.gn#...
> build/config/linux/BUILD.gn:71: # Don't bother running pkg-config for these X
> related libraries since it just
> On 2014/10/28 00:18:05, jamesr wrote:
> > hmm, the comment here seems like a lie given that we do have explicit
separate
> > pkg-config targets for many of these libs. could you update it please?
> 
> Sorry, I'm not familiar with this 'x11' dependency. Do you mean simply
removing
> the comment?
> 
> I'm also a bit confused by this 'x11' dependency, which seems to include a lot
> of dependencies when we also have separate dependency for xcomposite, xext,
etc.

PTAL

[Ben Chan, 2014-10-28 18:18:08]

benchan@chromium.org changed reviewers:
+ cmasone@chromium.org

[jamesr, 2014-10-28 19:25:10]

lgtm

[Ben Chan, 2014-10-28 19:25:36]

The CQ bit was checked by benchan@chromium.org

[Ben Chan, 2014-10-28 19:26:21]

The CQ bit was unchecked by benchan@chromium.org

[Ben Chan, 2014-10-28 22:46:34]

On 2014/10/28 19:25:10, jamesr wrote:
> lgtm

brettw: could you give OWNER lgtm if the CL lgtm, thanks!

[brettw, 2014-10-29 01:32:49]

lgtm

[Ben Chan, 2014-10-29 06:31:45]

The CQ bit was checked by benchan@chromium.org

[commit-bot: I haz the power, 2014-10-29 06:32:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/682893003/20001

[commit-bot: I haz the power, 2014-10-29 07:20:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-29 07:21:17]

Patchset 2 (id:??) landed as
https://crrev.com/407ead664abeab9534ceee416ef637de13c4e247
Cr-Commit-Position: refs/heads/master@{#301802}