Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 682883003: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed)

Created:
6 years, 1 month ago by RAGHURAM
Modified:
6 years, 1 month ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/WebKit/Source/bindings This step is to move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/WebKit/Source/bindings (Ref: binding-methods changed: static v8::Local<v8::Value> runCompiledScript(v8::Handle<v8::Script>, ExecutionContext*, v8::Isolate*) static v8::Local<v8::Value> runCompiledInternalScript(v8::Handle<v8::Script>, v8::Isolate*)) BUG=424446 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184511

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M Source/bindings/core/v8/PrivateScriptRunner.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptDebugServer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8ScriptRunner.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/V8ScriptRunner.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/WorkerScriptController.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
RAGHURAM
Please Review. Thanks & Regards
6 years, 1 month ago (2014-10-28 07:14:03 UTC) #2
haraken
LGTM
6 years, 1 month ago (2014-10-28 08:13:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/682883003/1
6 years, 1 month ago (2014-10-28 11:14:04 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 12:29:37 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184511

Powered by Google App Engine
This is Rietveld 408576698