Introduce TintedImageButton class.

Introduce TintedImageButton class.

-Adds a new class that extends ImageButton to allow custom tinting
 drawables on varios states such as pressed, focused, etc.
-Starts using TintedImageButton for ChromeShell.

BUG=427719
Committed: https://crrev.com/dccbf51c57d78a0ff6d0d6d659b70d1c3ecf10af
Cr-Commit-Position: refs/heads/master@{#301716}

[aurimas (slooooooooow), 2014-10-27 23:34:18]

aurimas@chromium.org changed reviewers:
+ dtrainor@chromium.org

[aurimas (slooooooooow), 2014-10-27 23:34:19]

Hey David,

Please take a look at this change.

Aurimas

[David Trainor- moved to gerrit, 2014-10-27 23:58:59]

looking awesome!  a few nits/suggestions, but this is going to be a really cool
change.

https://chromiumcodereview.appspot.com/682883002/diff/1/chrome/android/java/r...
File chrome/android/java/res/color/default_tint.xml (right):

https://chromiumcodereview.appspot.com/682883002/diff/1/chrome/android/java/r...
chrome/android/java/res/color/default_tint.xml:1: <?xml version="1.0"
encoding="utf-8"?>
Add the word btn or button in the name IMO.

https://chromiumcodereview.appspot.com/682883002/diff/1/chrome/android/java/s...
File
chrome/android/java/src/org/chromium/chrome/browser/widget/TintedImageButton.java
(right):

https://chromiumcodereview.appspot.com/682883002/diff/1/chrome/android/java/s...
chrome/android/java/src/org/chromium/chrome/browser/widget/TintedImageButton.java:19:
public class TintedImageButton extends ImageButton {
It looks like Android supports this by default with V21
(ImageView#setImageTintList(), not sure if it's exactly what you want though). 
Should we try to detect the version and use their APIs depending on the version
of the OS?  Do they have something like this in their compat library?

https://chromiumcodereview.appspot.com/682883002/diff/1/chrome/android/java/s...
chrome/android/java/src/org/chromium/chrome/browser/widget/TintedImageButton.java:50:
this.mTint = tint;
remove "this."

https://chromiumcodereview.appspot.com/682883002/diff/1/chrome/android/java/s...
chrome/android/java/src/org/chromium/chrome/browser/widget/TintedImageButton.java:51:
super.setColorFilter(tint.getColorForState(getDrawableState(), 0));
call updateTintColor() here?

https://chromiumcodereview.appspot.com/682883002/diff/1/chrome/android/java/s...
chrome/android/java/src/org/chromium/chrome/browser/widget/TintedImageButton.java:55:
int color = mTint.getColorForState(getDrawableState(), 0);
Remove temporary variable

https://chromiumcodereview.appspot.com/682883002/diff/1/chrome/android/shell/...
File
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java
(right):

https://chromiumcodereview.appspot.com/682883002/diff/1/chrome/android/shell/...
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java:52:
R.drawable.btn_toolbar_stop_loading_white_normal);
Eventually we should just name these btn_toolbar_stop_loading and get rid of
that xml file ("white" and "normal" will no longer be relevant if we're doing
all the state handling via tinting).

https://chromiumcodereview.appspot.com/682883002/diff/1/chrome/android/shell/...
File chrome/android/shell/res/layout/chrome_shell_activity.xml (right):

https://chromiumcodereview.appspot.com/682883002/diff/1/chrome/android/shell/...
chrome/android/shell/res/layout/chrome_shell_activity.xml:27:
chrome:tint="@color/default_tint"/>
Should we have a default button style that applies these automatically?

[aurimas (slooooooooow), 2014-10-28 18:11:16]

https://chromiumcodereview.appspot.com/682883002/diff/1/chrome/android/java/s...
File
chrome/android/java/src/org/chromium/chrome/browser/widget/TintedImageButton.java
(right):

https://chromiumcodereview.appspot.com/682883002/diff/1/chrome/android/java/s...
chrome/android/java/src/org/chromium/chrome/browser/widget/TintedImageButton.java:19:
public class TintedImageButton extends ImageButton {
On 2014/10/27 23:58:59, David Trainor wrote:
> It looks like Android supports this by default with V21
> (ImageView#setImageTintList(), not sure if it's exactly what you want though).

> Should we try to detect the version and use their APIs depending on the
version
> of the OS?  Do they have something like this in their compat library?

They do not have an appcompat version. This is essentially it. Updated to use
setImageTintList for API 21 and above.

https://chromiumcodereview.appspot.com/682883002/diff/1/chrome/android/java/s...
chrome/android/java/src/org/chromium/chrome/browser/widget/TintedImageButton.java:50:
this.mTint = tint;
On 2014/10/27 23:58:59, David Trainor wrote:
> remove "this."

Done.

https://chromiumcodereview.appspot.com/682883002/diff/1/chrome/android/java/s...
chrome/android/java/src/org/chromium/chrome/browser/widget/TintedImageButton.java:51:
super.setColorFilter(tint.getColorForState(getDrawableState(), 0));
On 2014/10/27 23:58:59, David Trainor wrote:
> call updateTintColor() here?

Done.

https://chromiumcodereview.appspot.com/682883002/diff/1/chrome/android/java/s...
chrome/android/java/src/org/chromium/chrome/browser/widget/TintedImageButton.java:55:
int color = mTint.getColorForState(getDrawableState(), 0);
On 2014/10/27 23:58:59, David Trainor wrote:
> Remove temporary variable

Done.

https://chromiumcodereview.appspot.com/682883002/diff/1/chrome/android/shell/...
File
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java
(right):

https://chromiumcodereview.appspot.com/682883002/diff/1/chrome/android/shell/...
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java:52:
R.drawable.btn_toolbar_stop_loading_white_normal);
On 2014/10/27 23:58:59, David Trainor wrote:
> Eventually we should just name these btn_toolbar_stop_loading and get rid of
> that xml file ("white" and "normal" will no longer be relevant if we're doing
> all the state handling via tinting).

Yeah, I agree, but I want to do it in a separate CL.

[David Trainor- moved to gerrit, 2014-10-28 18:15:38]

lgtm

[aurimas (slooooooooow), 2014-10-28 20:35:01]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2014-10-28 20:37:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/682883002/40001

[commit-bot: I haz the power, 2014-10-28 21:38:12]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-10-28 21:38:45]

Patchset 3 (id:??) landed as
https://crrev.com/dccbf51c57d78a0ff6d0d6d659b70d1c3ecf10af
Cr-Commit-Position: refs/heads/master@{#301716}