Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issue 682863002: Repack remoting resources into Chrome on Chrome OS (Closed)

Created:
6 years, 1 month ago by kelvinp
Modified:
6 years, 1 month ago
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@It2me_ChromeOS
Project:
chromium
Visibility:
Public.

Description

Repack remoting resources into Chrome on Chrome OS The Continue Dialog (along with a few other dialogs) in Remote Assistance references localized strings defined in rmeoting_strings.grd. To make Remote Assistance work on Chrome OS, we need to get those resources into Chrome. This CL 1. Modifies repack_locales.py to merge the generated strings from remoting_strings.grd into the merged resource packs (e.g. merge remoting/resource/en.pak -> en-US.pak). 2. Chrome currently supports more languages than remoting. This CL adds the missing languages into remoting_strings.grd. This is required to avoid compilation failures. The list of added locales are based-on on referencing other chrome grd files (e.g. generated_resources.grd). 3. remoting_strings.grds currently uses an overlapping resource ID range with chrome. To avoid conflicts, this CL reserves ids [29550-30000) for strings in remoting (see the changes in remoting/resources/resource_ids and tools/gritsettings/resource_ids). Committed: https://crrev.com/28f1077f6e22f69039d92fd5e3eac1fcded76a81 Cr-Commit-Position: refs/heads/master@{#301566}

Patch Set 1 : #

Patch Set 2 : Fix GN build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -26 lines) Patch
M chrome/chrome_repack_locales.gni View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_resources.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/tools/build/repack_locales.py View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/remoting.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/resources/BUILD.gn View 1 7 chunks +19 lines, -2 lines 0 comments Download
M remoting/resources/remoting_strings.grd View 1 6 chunks +64 lines, -0 lines 0 comments Download
D remoting/resources/resource_ids View 1 chunk +0 lines, -22 lines 0 comments Download
M tools/gritsettings/resource_ids View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
kelvinp
PTAL @jamie, can you help me to take a look at the changes in remoting_strings.grd. ...
6 years, 1 month ago (2014-10-27 23:41:14 UTC) #4
please use gerrit instead
tools/gritsettings/resource_ids LGTM
6 years, 1 month ago (2014-10-27 23:44:01 UTC) #6
sky
LGTM
6 years, 1 month ago (2014-10-27 23:52:19 UTC) #7
Jamie
lgtm
6 years, 1 month ago (2014-10-28 00:18:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/682863002/20001
6 years, 1 month ago (2014-10-28 00:19:50 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/11965) linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/28691)
6 years, 1 month ago (2014-10-28 00:32:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/682863002/40001
6 years, 1 month ago (2014-10-28 03:47:41 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:40001)
6 years, 1 month ago (2014-10-28 05:00:07 UTC) #15
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 05:01:04 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/28f1077f6e22f69039d92fd5e3eac1fcded76a81
Cr-Commit-Position: refs/heads/master@{#301566}

Powered by Google App Engine
This is Rietveld 408576698