Issue 682843003: Remove redundant SetUp() override from TextfieldTest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 682843003: Remove redundant SetUp() override from TextfieldTest. (Closed)

Created:
6 years, 1 month ago by dcheng

Modified:
6 years, 1 month ago

Reviewers:
msw

CC:
chromium-reviews, nona+watch_chromium.org, penghuang+watch_chromium.org, James Su, tfarina, yukishiino+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove redundant SetUp() override from TextfieldTest. BUG=none R=msw@chromium.org Committed: https://crrev.com/c739a92adb1a77b52d4eb0944d534ed99209eeec Cr-Commit-Position: refs/heads/master@{#301577}

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	ui/views/controls/textfield/textfield_unittest.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/682843003/1

6 years, 1 month ago (2014-10-28 00:32:58 UTC) #4

commit-bot: I haz the power

6 years, 1 month ago (2014-10-28 06:47:14 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/c739a92adb1a77b52d4eb0944d534ed99209eeec
Cr-Commit-Position: refs/heads/master@{#301577}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages