Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 682833005: Remove tests which only test getPropertyCSSValue (Closed)

Created:
6 years, 1 month ago by Timothy Loh
Modified:
6 years, 1 month ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove tests which only test getPropertyCSSValue getPropertyCSSValue, CSSValue, etc. are no longer web-exposed and about to be deleted as soon as tests no longer depend on them. BUG=428595 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185089

Patch Set 1 #

Patch Set 2 : missed an expectation file :| #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -223 lines) Patch
D LayoutTests/http/tests/security/cross-origin-css-primitive.html View 1 chunk +0 lines, -34 lines 0 comments Download
D LayoutTests/http/tests/security/cross-origin-css-primitive-expected.txt View 1 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/http/tests/security/resources/cross-origin-css-primitive-iframe.html View 1 chunk +0 lines, -27 lines 0 comments Download
D LayoutTests/platform/win/transforms/2d/README View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/transforms/2d/transform-value-types.html View 1 chunk +0 lines, -100 lines 0 comments Download
D LayoutTests/transforms/2d/transform-value-types-expected.txt View 1 chunk +0 lines, -38 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Timothy Loh
6 years, 1 month ago (2014-11-10 20:05:57 UTC) #2
alancutter (OOO until 2018)
lgtm
6 years, 1 month ago (2014-11-10 22:39:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/682833005/20001
6 years, 1 month ago (2014-11-10 22:40:31 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/35687)
6 years, 1 month ago (2014-11-11 00:40:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/682833005/20001
6 years, 1 month ago (2014-11-11 01:05:30 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 01:53:46 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 185089

Powered by Google App Engine
This is Rietveld 408576698