Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 682813005: Plugin Power Saver: Fix (probably rare) crash in PepperPluginInstanceImpl. (Closed)

Created:
6 years, 1 month ago by tommycli
Modified:
6 years, 1 month ago
Reviewers:
raymes
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Plugin Power Saver: Fix (probably rare) crash in PepperPluginInstanceImpl. Wasn't able to repro personally, but based on stack traces, crash reports, and sadrul@'s diagnosis, this should probably fix the crash in below bug. BUG=430228 Committed: https://crrev.com/4d61f56bd68e7efe982276254c7abb48852e65ca Cr-Commit-Position: refs/heads/master@{#302848}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -26 lines) Patch
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 2 chunks +27 lines, -26 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
tommycli
sadrul / raymes: I wasn't able to repro the crash on either Linux or Windows. ...
6 years, 1 month ago (2014-11-05 01:04:56 UTC) #2
raymes
lgtm
6 years, 1 month ago (2014-11-05 05:03:59 UTC) #3
sadrul
I am not familiar with the relevant code to review. But thanks for the speedy ...
6 years, 1 month ago (2014-11-05 05:13:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/682813005/1
6 years, 1 month ago (2014-11-05 18:44:38 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-05 19:34:08 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 19:34:48 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d61f56bd68e7efe982276254c7abb48852e65ca
Cr-Commit-Position: refs/heads/master@{#302848}

Powered by Google App Engine
This is Rietveld 408576698