Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 682813004: Adds a histogram to measure the difference between the bandwidth estimate at 2 seconds and 20 ... (Closed)

Created:
6 years, 1 month ago by Stefan
Modified:
6 years, 1 month ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, mflodman_chromium_OOO
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adds a histogram to measure the difference between the bandwidth estimate at 2 seconds and 20 seconds into a WebRTC call. BUG=425925 R=asvitkine@chromium.org Committed: https://crrev.com/7d6cf9d53051f186c64c4cc4661c3b241ebd71f0 Cr-Commit-Position: refs/heads/master@{#302672}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Only cover positive diff of @20 - @2 #

Patch Set 3 : Corrected description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
Stefan
6 years, 1 month ago (2014-11-04 13:26:51 UTC) #1
Stefan
6 years, 1 month ago (2014-11-04 13:27:03 UTC) #2
Alexei Svitkine (slow)
https://codereview.chromium.org/682813004/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/682813004/diff/1/tools/metrics/histograms/histograms.xml#newcode39714 tools/metrics/histograms/histograms.xml:39714: + The difference between the bandwidth estimate at 2 ...
6 years, 1 month ago (2014-11-04 15:33:03 UTC) #3
Stefan
https://codereview.chromium.org/682813004/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/682813004/diff/1/tools/metrics/histograms/histograms.xml#newcode39714 tools/metrics/histograms/histograms.xml:39714: + The difference between the bandwidth estimate at 2 ...
6 years, 1 month ago (2014-11-04 15:34:59 UTC) #4
Stefan
On 2014/11/04 15:34:59, Stefan wrote: > https://codereview.chromium.org/682813004/diff/1/tools/metrics/histograms/histograms.xml > File tools/metrics/histograms/histograms.xml (right): > > https://codereview.chromium.org/682813004/diff/1/tools/metrics/histograms/histograms.xml#newcode39714 > ...
6 years, 1 month ago (2014-11-04 15:43:10 UTC) #5
Alexei Svitkine (slow)
lgtm
6 years, 1 month ago (2014-11-04 18:14:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/682813004/40001
6 years, 1 month ago (2014-11-04 19:40:16 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-04 21:22:23 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 21:23:25 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7d6cf9d53051f186c64c4cc4661c3b241ebd71f0
Cr-Commit-Position: refs/heads/master@{#302672}

Powered by Google App Engine
This is Rietveld 408576698