Issue 682793005: Removed non-existent files from gyp and GN builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 682793005: Removed non-existent files from gyp and GN builds. (Closed)

Created:
6 years, 1 month ago by mvstanton

Modified:
6 years, 1 month ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	BUILD.gn	View		2 chunks	+0 lines, -2 lines	0 comments	Download
	M	tools/gyp/v8.gyp	View		2 chunks	+0 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

mvstanton

Hi Yang, just a tiny thing I noticed building on windows. PTAL, thx, --Michael

6 years, 1 month ago (2014-10-28 11:44:26 UTC) #2

Yang

On 2014/10/28 11:44:26, mvstanton wrote: > Hi Yang, just a tiny thing I noticed building ...

6 years, 1 month ago (2014-10-28 11:49:54 UTC) #3

mvstanton

6 years, 1 month ago (2014-10-28 12:10:00 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 24932 (presubmit successful).