Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 682793002: Remove SimpleFontData::create only used by SVG Fonts (Closed)

Created:
6 years, 1 month ago by rwlbuis
Modified:
6 years, 1 month ago
Reviewers:
pdr.
CC:
blink-reviews, Rik, danakj, krit, f(malita), jbroman, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove SimpleFontData::create only used by SVG Fonts SVG Fonts were removed in: https://codereview.chromium.org/656913006 That removed the last caller to SimpleFontData::create. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184486

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M Source/platform/fonts/SimpleFontData.h View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rwlbuis
PTAL
6 years, 1 month ago (2014-10-27 21:45:30 UTC) #2
pdr.
lgtm
6 years, 1 month ago (2014-10-27 21:53:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/682793002/1
6 years, 1 month ago (2014-10-27 21:54:13 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 23:43:25 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 184486

Powered by Google App Engine
This is Rietveld 408576698