chrome/browser/ui/views/tabs/tab_drag_controller.cc - Issue 682763002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/tab_drag_controller.cc

Issue 682763002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/tabs/tab_drag_controller.h ('k') | chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/tabs/tab_drag_controller.cc

diff --git a/chrome/browser/ui/views/tabs/tab_drag_controller.cc b/chrome/browser/ui/views/tabs/tab_drag_controller.cc

index 07d2fbc011a728b10f104ae0ea3de4736db8ec45..7bf927b132ea9e9800ba2577105632553ea64e97 100644

--- a/chrome/browser/ui/views/tabs/tab_drag_controller.cc

+++ b/chrome/browser/ui/views/tabs/tab_drag_controller.cc

@@ -136,8 +136,7 @@ void OffsetX(int x_offset, std::vector<gfx::Rect>* rects) {

// false before WorkspaceLayoutManager sees the visibility change.

class WindowPositionManagedUpdater : public views::WidgetObserver {

public:

- virtual void OnWidgetVisibilityChanged(views::Widget* widget,

- bool visible) override {

+ void OnWidgetVisibilityChanged(views::Widget* widget, bool visible) override {

SetWindowPositionManaged(widget->GetNativeWindow(), false);

}

};

@@ -153,7 +152,7 @@ class EscapeTracker : public ui::EventHandler {

private:

// ui::EventHandler:

- virtual void OnKeyEvent(ui::KeyEvent* key) override {

+ void OnKeyEvent(ui::KeyEvent* key) override {

if (key->type() == ui::ET_KEY_PRESSED &&

key->key_code() == ui::VKEY_ESCAPE) {

escape_callback_.Run();